Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: src/mips64/code-stubs-mips64.cc

Issue 864713003: MIPS: Calls to the CallIC miss handler looked up the receiver incorrectly. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/code-stubs-mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS64 7 #if V8_TARGET_ARCH_MIPS64
8 8
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 2985 matching lines...) Expand 10 before | Expand all | Expand 10 after
2996 __ JumpIfSmi(a1, &non_function); 2996 __ JumpIfSmi(a1, &non_function);
2997 2997
2998 // Goto slow case if we do not have a function. 2998 // Goto slow case if we do not have a function.
2999 __ GetObjectType(a1, a4, a4); 2999 __ GetObjectType(a1, a4, a4);
3000 __ Branch(&slow, ne, a4, Operand(JS_FUNCTION_TYPE)); 3000 __ Branch(&slow, ne, a4, Operand(JS_FUNCTION_TYPE));
3001 __ Branch(&have_js_function); 3001 __ Branch(&have_js_function);
3002 } 3002 }
3003 3003
3004 3004
3005 void CallICStub::GenerateMiss(MacroAssembler* masm) { 3005 void CallICStub::GenerateMiss(MacroAssembler* masm) {
3006 // Get the receiver of the function from the stack; 1 ~ return address. 3006 // Get the receiver of the function from the stack.
3007 __ ld(a4, MemOperand(sp, (arg_count() + 1) * kPointerSize)); 3007 __ ld(a4, MemOperand(sp, arg_count() * kPointerSize));
3008 3008
3009 { 3009 {
3010 FrameScope scope(masm, StackFrame::INTERNAL); 3010 FrameScope scope(masm, StackFrame::INTERNAL);
3011 3011
3012 // Push the receiver and the function and feedback info. 3012 // Push the receiver and the function and feedback info.
3013 __ Push(a4, a1, a2, a3); 3013 __ Push(a4, a1, a2, a3);
3014 3014
3015 // Call the entry. 3015 // Call the entry.
3016 IC::UtilityId id = GetICState() == DEFAULT ? IC::kCallIC_Miss 3016 IC::UtilityId id = GetICState() == DEFAULT ? IC::kCallIC_Miss
3017 : IC::kCallIC_Customization_Miss; 3017 : IC::kCallIC_Customization_Miss;
(...skipping 2197 matching lines...) Expand 10 before | Expand all | Expand 10 after
5215 kStackUnwindSpace, kInvalidStackOffset, 5215 kStackUnwindSpace, kInvalidStackOffset,
5216 MemOperand(fp, 6 * kPointerSize), NULL); 5216 MemOperand(fp, 6 * kPointerSize), NULL);
5217 } 5217 }
5218 5218
5219 5219
5220 #undef __ 5220 #undef __
5221 5221
5222 } } // namespace v8::internal 5222 } } // namespace v8::internal
5223 5223
5224 #endif // V8_TARGET_ARCH_MIPS64 5224 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/mips/code-stubs-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698