Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Side by Side Diff: src/mips/code-stubs-mips.cc

Issue 864713003: MIPS: Calls to the CallIC miss handler looked up the receiver incorrectly. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/mips64/code-stubs-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS 7 #if V8_TARGET_ARCH_MIPS
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/bootstrapper.h" 10 #include "src/bootstrapper.h"
(...skipping 2910 matching lines...) Expand 10 before | Expand all | Expand 10 after
2921 __ JumpIfSmi(a1, &non_function); 2921 __ JumpIfSmi(a1, &non_function);
2922 2922
2923 // Goto slow case if we do not have a function. 2923 // Goto slow case if we do not have a function.
2924 __ GetObjectType(a1, t0, t0); 2924 __ GetObjectType(a1, t0, t0);
2925 __ Branch(&slow, ne, t0, Operand(JS_FUNCTION_TYPE)); 2925 __ Branch(&slow, ne, t0, Operand(JS_FUNCTION_TYPE));
2926 __ Branch(&have_js_function); 2926 __ Branch(&have_js_function);
2927 } 2927 }
2928 2928
2929 2929
2930 void CallICStub::GenerateMiss(MacroAssembler* masm) { 2930 void CallICStub::GenerateMiss(MacroAssembler* masm) {
2931 // Get the receiver of the function from the stack; 1 ~ return address. 2931 // Get the receiver of the function from the stack.
2932 __ lw(t0, MemOperand(sp, (arg_count() + 1) * kPointerSize)); 2932 __ lw(t0, MemOperand(sp, arg_count() * kPointerSize));
2933 2933
2934 { 2934 {
2935 FrameScope scope(masm, StackFrame::INTERNAL); 2935 FrameScope scope(masm, StackFrame::INTERNAL);
2936 2936
2937 // Push the receiver and the function and feedback info. 2937 // Push the receiver and the function and feedback info.
2938 __ Push(t0, a1, a2, a3); 2938 __ Push(t0, a1, a2, a3);
2939 2939
2940 // Call the entry. 2940 // Call the entry.
2941 IC::UtilityId id = GetICState() == DEFAULT ? IC::kCallIC_Miss 2941 IC::UtilityId id = GetICState() == DEFAULT ? IC::kCallIC_Miss
2942 : IC::kCallIC_Customization_Miss; 2942 : IC::kCallIC_Customization_Miss;
(...skipping 2232 matching lines...) Expand 10 before | Expand all | Expand 10 after
5175 kStackUnwindSpace, kInvalidStackOffset, 5175 kStackUnwindSpace, kInvalidStackOffset,
5176 MemOperand(fp, 6 * kPointerSize), NULL); 5176 MemOperand(fp, 6 * kPointerSize), NULL);
5177 } 5177 }
5178 5178
5179 5179
5180 #undef __ 5180 #undef __
5181 5181
5182 } } // namespace v8::internal 5182 } } // namespace v8::internal
5183 5183
5184 #endif // V8_TARGET_ARCH_MIPS 5184 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « no previous file | src/mips64/code-stubs-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698