Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 864693002: Treat UA rules like author rules when matching. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
ojan, abarth-chromium
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Treat UA rules like author rules when matching. Sky doesn't have a concept of UA rules, just some default style rules you can override. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/68582549c0935d80c4fb08cdf67ecd26e3f9b856

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -32 lines) Patch
M sky/engine/core/css/resolver/StyleResolver.h View 1 chunk +1 line, -3 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.cpp View 2 chunks +12 lines, -29 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
5 years, 11 months ago (2015-01-21 02:43:31 UTC) #2
ojan
lgtm
5 years, 11 months ago (2015-01-21 02:48:08 UTC) #3
esprehn
5 years, 11 months ago (2015-01-21 02:49:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
68582549c0935d80c4fb08cdf67ecd26e3f9b856 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698