Issue 864613002: Remove Element::textFromChildren().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 864613002: Remove Element::textFromChildren(). (Closed)

Created:
5 years, 11 months ago by esprehn

Modified:
5 years, 11 months ago

Reviewers:
abarth-chromium, ojan

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Remove Element::textFromChildren(). Instead just use textContent() and teach HTMLStyleElement how to atomize its children. I also added the optimization to Node::textContent so that Text just returns its value instead of allocating a new buffer which avoids malloc and copy when getting the textContent of text. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c86cb32c3d51216460cbd32c79c1a812541a66e1

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -44 lines)			Patch
M	sky/engine/core/dom/Element.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/dom/Element.cpp	View	1 chunk	+0 lines, -40 lines	0 comments	Download
M	sky/engine/core/dom/Node.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/engine/core/html/HTMLStyleElement.cpp	View	2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

esprehn

5 years, 11 months ago (2015-01-20 22:26:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c86cb32c3d51216460cbd32c79c1a812541a66e1 (presubmit successful).