Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/android/BUILD.gn

Issue 864563002: Separate JNI registration with initialization (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/android/jni_onload_delegate.h ('K') | « chrome/BUILD.gn ('k') | chrome/app/android/chrome_android_initializer.h » ('j') | chrome/app/android/chrome_jni_onload.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/BUILD.gn
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
index a8fd756acb9196a2e20533e27e973bfcf9d6d71b..c9a8e9e0124aba33554d57ddee1c687a15c49598 100644
--- a/chrome/android/BUILD.gn
+++ b/chrome/android/BUILD.gn
@@ -187,9 +187,6 @@ group("chrome_shell_base") {
shared_library("chrome_shell") {
testonly = true
sources = [
- # This file must always be included in the shared_library step to ensure
- # JNI_OnLoad is exported.
- "//chrome/app/android/chrome_jni_onload.cc",
"shell/chrome_main_delegate_chrome_shell_android.cc",
"shell/chrome_main_delegate_chrome_shell_android.h",
]
@@ -210,9 +207,6 @@ shared_library("chrome_shell") {
shared_library("chrome_sync_shell") {
testonly = true
sources = [
- # This file must always be included in the shared_library step to ensure
- # JNI_OnLoad is exported.
- #"//chrome/app/android/chrome_jni_onload.cc",
#"sync_shell/chrome_main_delegate_chrome_sync_shell_android.cc",
#"sync_shell/chrome_main_delegate_chrome_sync_shell_android.h",
]
« base/android/jni_onload_delegate.h ('K') | « chrome/BUILD.gn ('k') | chrome/app/android/chrome_android_initializer.h » ('j') | chrome/app/android/chrome_jni_onload.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698