chrome/android/BUILD.gn - Issue 864563002: Separate JNI registration with initialization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/BUILD.gn

Issue 864563002: Separate JNI registration with initialization (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments and sync Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/BUILD.gn

diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn

index a8fd756acb9196a2e20533e27e973bfcf9d6d71b..c9a8e9e0124aba33554d57ddee1c687a15c49598 100644

--- a/chrome/android/BUILD.gn

+++ b/chrome/android/BUILD.gn

@@ -187,9 +187,6 @@ group("chrome_shell_base") {

shared_library("chrome_shell") {

testonly = true

sources = [

- # This file must always be included in the shared_library step to ensure

- # JNI_OnLoad is exported.

- "//chrome/app/android/chrome_jni_onload.cc",

"shell/chrome_main_delegate_chrome_shell_android.cc",

"shell/chrome_main_delegate_chrome_shell_android.h",

]

@@ -210,9 +207,6 @@ shared_library("chrome_shell") {

shared_library("chrome_sync_shell") {

testonly = true

sources = [

- # This file must always be included in the shared_library step to ensure

- # JNI_OnLoad is exported.

- #"//chrome/app/android/chrome_jni_onload.cc",

#"sync_shell/chrome_main_delegate_chrome_sync_shell_android.cc",

#"sync_shell/chrome_main_delegate_chrome_sync_shell_android.h",

]

« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/app/android/chrome_android_initializer.h » ('j') | no next file with comments »