Separate JNI registration with initialization

chrome/app/android/chrome_jni_onload.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/android/jni_android.h"
+#include "base/android/jni_onload_delegate.h"
+#include "chrome/app/android/chrome_android_initializer.h"
+#include "content/public/app/content_jni_onload.h"
 
-#include "base/android/jni_android.h"
-#include "chrome/app/android/chrome_android_initializer.h"
-#include "chrome/app/android/chrome_main_delegate_android.h"
+namespace {
+
+class ChromeJNIOnLoadDelegate : public base::android::JNIOnLoadDelegate {
+ public:
+  virtual bool RegisterJNI(JNIEnv* env) override;

[David Trainor- moved to gerrit, 2015/01/28 19:13:25]

I'm not 100% sure, but I just looked at web_contents_impl.h, to check.  I don't
think you need virtual if you use override (the new non-macro version).  Same
with method below.

[michaelbai, 2015/01/28 19:50:58]

Done.

+  virtual bool Init() override;
+};
+
+bool ChromeJNIOnLoadDelegate::RegisterJNI(JNIEnv* env) {
+  return true;
+}
+
+bool ChromeJNIOnLoadDelegate::Init() {
+  // TODO(michaelbai): Move the JNI registration from RunChrome() to
+  // RegisterJNI().
+  return RunChrome();
+}
+
+}  // namespace
+
 
 // This is called by the VM when the shared library is first loaded.
-// Note that this file must be included in the final shared_library build step
-// and not in a static library or the JNI_OnLoad symbol won't be included
-// because the Android build is compiled with exclude-libs=ALL to reduce symbol
-// size.
 JNI_EXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) {
-  return RunChrome(vm, ChromeMainDelegateAndroid::Create());
+  ChromeJNIOnLoadDelegate delegate;
+  if (!content::android::OnJNIOnLoad(vm, &delegate))
+    return -1;
+
+  return JNI_VERSION_1_4;
 }