Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Side by Side Diff: content/shell/android/shell_library_loader.cc

Issue 864563002: Separate JNI registration with initialization (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments and sync Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/android/jni_android.h" 5 #include "base/android/jni_android.h"
6 #include "base/android/jni_registrar.h" 6 #include "base/android/jni_onload_delegate.h"
7 #include "base/android/library_loader/library_loader_hooks.h" 7 #include "content/public/app/content_jni_onload.h"
8 #include "base/basictypes.h"
9 #include "base/debug/debugger.h"
10 #include "base/logging.h"
11 #include "content/public/app/android_library_loader_hooks.h"
12 #include "content/public/app/content_main.h" 8 #include "content/public/app/content_main.h"
13 #include "content/public/browser/android/compositor.h" 9 #include "content/public/browser/android/compositor.h"
14 #include "content/shell/android/shell_jni_registrar.h" 10 #include "content/shell/android/shell_jni_registrar.h"
15 #include "content/shell/app/shell_main_delegate.h" 11 #include "content/shell/app/shell_main_delegate.h"
16 12
13 namespace {
14
15 class ShellJNIOnLoadDelegate : public base::android::JNIOnLoadDelegate {
16 public:
17 bool RegisterJNI(JNIEnv* env) override;
18 bool Init() override;
19 };
20
21 bool ShellJNIOnLoadDelegate::RegisterJNI(JNIEnv* env) {
22 return content::android::RegisterShellJni(env);
23 }
24
25 bool ShellJNIOnLoadDelegate::Init() {
26 content::Compositor::Initialize();
27 content::SetContentMainDelegate(new content::ShellMainDelegate());
28 return true;
29 }
30
31 } // namespace
32
33
17 // This is called by the VM when the shared library is first loaded. 34 // This is called by the VM when the shared library is first loaded.
18 JNI_EXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) { 35 JNI_EXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) {
19 36 ShellJNIOnLoadDelegate delegate;
20 base::android::SetLibraryLoadedHook(&content::LibraryLoaded); 37 if (!content::android::OnJNIOnLoad(vm, &delegate))
21
22 base::android::InitVM(vm);
23 JNIEnv* env = base::android::AttachCurrentThread();
24
25 if (!base::android::RegisterLibraryLoaderEntryHook(env))
26 return -1; 38 return -1;
27 39
28 // To be called only from the UI thread. If loading the library is done on
29 // a separate thread, this should be moved elsewhere.
30 if (!content::android::RegisterShellJni(env))
31 return -1;
32
33 content::Compositor::Initialize();
34 content::SetContentMainDelegate(new content::ShellMainDelegate());
35 return JNI_VERSION_1_4; 40 return JNI_VERSION_1_4;
36 } 41 }
OLDNEW
« no previous file with comments | « content/shell/android/browsertests_apk/content_browser_tests_jni_onload.cc ('k') | testing/android/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698