gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt - Issue 864513004: gpu: introduce glCopySubTextureCHROMIUM

Side by Side Diff: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt

Issue 864513004: gpu: introduce glCopySubTextureCHROMIUM (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address nits Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 Name	1 Name

2	2

3 CHROMIUM_copy_texture	3 CHROMIUM_copy_texture

4	4

5 Name Strings	5 Name Strings

6	6

7 GL_CHROMIUM_copy_texture	7 GL_CHROMIUM_copy_texture

8	8

9 Version	9 Version

10	10

(...skipping 18 matching lines...) Expand all Loading...
29 If GL_UNPACK_PREMULTIPLY_ALPHA_CHROMIUM and	29 If GL_UNPACK_PREMULTIPLY_ALPHA_CHROMIUM and

30 GL_UNPACK_UNPREMULTIPLY_ALPHA_CHROMIUM are enabled. Then no alpha	30 GL_UNPACK_UNPREMULTIPLY_ALPHA_CHROMIUM are enabled. Then no alpha

31 processing occurs. This is the equivalent of having neither flag set.	31 processing occurs. This is the equivalent of having neither flag set.

32	32

33 The extension also supports copying BGRA textures and copying	33 The extension also supports copying BGRA textures and copying

34 EXTERNAL_OES texture to BGRA texture, which is not explicitly	34 EXTERNAL_OES texture to BGRA texture, which is not explicitly

35 granted by EXT_texture_format_BGRA8888.	35 granted by EXT_texture_format_BGRA8888.

36	36

37 New Procedures and Functions	37 New Procedures and Functions

38	38

39 void glCopyTextureCHROMIUM (GLenum target, GLenum source_id,	39 The command

40 GLenum dest_id, GLint level,	40

41 GLint internal_format, GLenum dest_type)	41 void glCopyTextureCHROMIUM (GLenum target, GLenum source_id,

	42 GLenum dest_id, GLint level,

	43 GLint internal_format, GLenum dest_type)

42	44

43 Copies the contents of texture referred to by <source_id> to texture	45 Copies the contents of texture referred to by <source_id> to texture

44 <dest_id>.	46 <dest_id>.

45	47

46 Texture level 0 is copied from the source image to level <level> of the	48 Texture level 0 is copied from the source image to level <level> of the

47 destination texture. The level parameter must be 0 at present.	49 destination texture. The level parameter must be 0 at present.

48	50

49 The internal format of the destination texture is converted to that	51 The internal format of the destination texture is converted to that

50 specified by <internal_format>. Must be one of the following symbolic	52 specified by <internal_format>. Must be one of the following symbolic

51 constants: GL_RGB, GL_RGBA	53 constants: GL_RGB, GL_RGBA

(...skipping 31 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
83 INVALID_VALUE is generated if textures corresponding to <dest_id> have not	85 INVALID_VALUE is generated if textures corresponding to <dest_id> have not

84 been bound as GL_TEXTURE_2D object.	86 been bound as GL_TEXTURE_2D object.

85	87

86 INVALID_VALUE is generated if textures corresponding to <source_id> have not	88 INVALID_VALUE is generated if textures corresponding to <source_id> have not

87 been bound as GL_TEXTURE_2D, GL_TEXTURE_RECTANGLE_ARB or	89 been bound as GL_TEXTURE_2D, GL_TEXTURE_RECTANGLE_ARB or

88 GL_TEXTURE_EXTERNAL_OES objects.	90 GL_TEXTURE_EXTERNAL_OES objects.

89	91

90 INVALID_VALUE is generated if <level> is not a valid level of the	92 INVALID_VALUE is generated if <level> is not a valid level of the

91 destination texture, or if level 0 of the source texture is not defined.	93 destination texture, or if level 0 of the source texture is not defined.

92	94

	95 The command

	96

	97 void glCopySubTextureCHROMIUM (GLenum target, GLenum source_id,

	98 GLenum dest_id, GLint level,

	99 GLint xoffset, GLint yoffset)

	100

	101 Copies the sub contents of texture referred to by <source_id> to texture

	102 <dest_id>.
	Ken Russell (switch to Gerrit) 2015/01/24 01:33:24 Please expand upon this sentence and say exactly w Please expand upon this sentence and say exactly what it does to the texture \|dest_id\|. glCopyTextureCHROMIUM is ambiguous about this; it's worth expanding its documentation to say that it reallocates the destination texture to be the same size as the source texture. This function's documentation should explicitly say that it copies the contents of the texture \|source_id\| to a location in the texture \|dest_id\| without reallocating the destination texture. dshwang 2015/02/10 18:11:55 Yes, I explicitly explain this for glCopyTextureCH Show quoted text On 2015/01/24 01:33:24, Ken Russell wrote: > Please expand upon this sentence and say exactly what it does to the texture > \|dest_id\|. glCopyTextureCHROMIUM is ambiguous about this; it's worth expanding > its documentation to say that it reallocates the destination texture to be the > same size as the source texture. Yes, I explicitly explain this for glCopyTextureCHROMIUM Show quoted text > This function's documentation should explicitly say that it copies the contents > of the texture \|source_id\| to a location in the texture \|dest_id\| without > reallocating the destination texture. Yes, I explicitly explain this also.
	103

	104 See CopyTextureCHROMIUM for the interpretation of the <target> and <level>

	105 arguments.
	Ken Russell (switch to Gerrit) 2015/01/24 01:33:24 Are you going to generalize the CopySubTexture var Are you going to generalize the CopySubTexture variant to handle level > 0? The code handles it. If so then please don't refer to CopyTextureCHROMIUM for the level argument, but define its semantics here. dshwang 2015/02/10 18:11:55 level > 0 will never be supported because glFrameb Show quoted text On 2015/01/24 01:33:24, Ken Russell wrote: > Are you going to generalize the CopySubTexture variant to handle level > 0? The > code handles it. If so then please don't refer to CopyTextureCHROMIUM for the > level argument, but define its semantics here. level > 0 will never be supported because glFramebufferTexture2D doesn't support level > 0. CopyTextureCHROMIUM implementation requires <dest_id> texture bound to FBO. https://www.khronos.org/opengles/sdk/docs/man/xhtml/glFramebufferTexture2D.xml
	106

	107 <xoffset> and <yoffset> specify a texel offset in the x and y direction

	108 respectively within the destination texture.

	109

	110 INVALID_OPERATION is generated if source internal_format and destination

	111 internal_format are not one of the valid formats described above.

	112

	113 INVALID_VALUE is generated if <target> is not GL_TEXTURE_2D.

	114

	115 INVALID_OPERATION is generated if the destination texture has not been

	116 defined.

	117

	118 INVALID_VALUE is generated if <level> is less than 0.

	119

	120 INVALID_VALUE may be generated if <level> >log2(max), where max is

	121 the returned value of GL_MAX_TEXTURE_SIZE.

	122

	123 INVALID_VALUE is generated if <xoffset> < 0 , or <yoffset> < 0.

	124

	125 INVALID_VALUE is generated if (<xoffset> + source_width) > dest_width,

	126 or (<yoffset> + source_height) > dest_height.

	127

93 Errors	128 Errors

94	129

95 None.	130 None.

96	131

97 New Tokens	132 New Tokens

98	133

99 None.	134 None.

100	135

101 New State	136 New State

102	137

103 None.	138 None.

104	139

105 Revision History	140 Revision History

106	141

107 8/1/2011 Documented the extension	142 8/1/2011 Documented the extension

108 7/4/2013 Add a new parameter dest_type to glCopyTextureCHROMIUM()	143 7/4/2013 Add a new parameter dest_type to glCopyTextureCHROMIUM()

109 16/7/2014 Add GL_TEXTURE_RECTANGLE_ARB as valid source_id target.	144 16/7/2014 Add GL_TEXTURE_RECTANGLE_ARB as valid source_id target.

OLD	NEW

« no previous file with comments | « cc/resources/resource_provider.cc ('k') | gpu/GLES2/gl2chromium_autogen.h » ('j') | gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc » ('J')