Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 864503002: Add ability to specify gyp dir to gyp_to_android. (Closed)

Created:
5 years, 11 months ago by scroggo
Modified:
5 years, 11 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add ability to specify gyp dir to gyp_to_android. When running gyp_to_android inside a Skia tree, it uses the gyp program in third_party/externals. Inside an Android tree, we need to use a different location for gyp (the Android copy of Skia, in external/skia, does not contain third_party/externals). The bot handles this by importing gyp_to_android and running its main function directly. Add command line arguments so a human can directly run gyp_to_android. Committed: https://skia.googlesource.com/skia/+/8fd8d38626ebb84d47ed8ba155efecb241fed6dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M platform_tools/android/bin/gyp_to_android.py View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
scroggo
5 years, 11 months ago (2015-01-20 16:40:00 UTC) #2
borenet
LGTM
5 years, 11 months ago (2015-01-20 18:16:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864503002/1
5 years, 11 months ago (2015-01-20 18:27:51 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 18:39:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8fd8d38626ebb84d47ed8ba155efecb241fed6dc

Powered by Google App Engine
This is Rietveld 408576698