Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 864483002: [ia32] Require SSE2. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ia32] Require SSE2. This way we stay in sync with what Chromium does and we reduce the number of bugs caused by 80-to-{32,64}-bit rounding errors. It's also a requirement for switching to signaling NaN for FixedDoubleArray holes. R=jkummerow@chromium.org Committed: https://crrev.com/655b112466e3d9138e07f78188f4fc5fdc16980c Cr-Commit-Position: refs/heads/master@{#26154}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M build/toolchain.gypi View 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
5 years, 11 months ago (2015-01-20 12:12:50 UTC) #1
Jakob Kummerow
LGTM. I don't think the big comment adds much value (we know what SSE2 is), ...
5 years, 11 months ago (2015-01-20 12:17:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864483002/1
5 years, 11 months ago (2015-01-20 12:24:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-20 12:53:49 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 12:53:59 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/655b112466e3d9138e07f78188f4fc5fdc16980c
Cr-Commit-Position: refs/heads/master@{#26154}

Powered by Google App Engine
This is Rietveld 408576698