Issue 864453002: Remove bogus filter from runtime-profiler tracing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 864453002: Remove bogus filter from runtime-profiler tracing.

Created:
5 years, 11 months ago by Michael Starzinger

Modified:
5 years, 11 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Remove bogus filter from runtime-profiler tracing. R=jkummerow@chromium.org

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/runtime-profiler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

5 years, 11 months ago (2015-01-20 09:36:59 UTC) #3

To summarize offline discussion: the reason for this check is to avoid excessive
tracing output. Without it, when a hot function is marked for optimization over
and over again, but doesn't pass the --hydrogen-filter, there are thousands of
lines of useless --trace-opt output, which is annoying.

That said, I don't feel strongly about it, and we can remove the filter if that
makes you happy.

Expand Messages | Collapse Messages