Changes to enable HTML5 autoplay for voice search.

content/browser/android/content_view_core_impl.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_
 #define CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_
 
 #include <vector>
 
 #include "base/android/jni_android.h"
@@ skipping 38 matching lines @@
 
   // ContentViewCore implementation.
   virtual base::android::ScopedJavaLocalRef<jobject> GetJavaObject() OVERRIDE;
   virtual WebContents* GetWebContents() const OVERRIDE;
   virtual ui::ViewAndroid* GetViewAndroid() const OVERRIDE;
   virtual ui::WindowAndroid* GetWindowAndroid() const OVERRIDE;
   virtual scoped_refptr<cc::Layer> GetLayer() const OVERRIDE;
   virtual void LoadUrl(NavigationController::LoadURLParams& params) OVERRIDE;
   virtual jint GetCurrentRenderProcessId(JNIEnv* env, jobject obj) OVERRIDE;
   virtual void ShowPastePopup(int x, int y) OVERRIDE;
+  void DisableMediaAutoplay(JNIEnv* env, jobject obj);

[David Trainor- moved to gerrit, 2013/11/26 18:59:32]

Can this be SetMediaAutoplayEnabled()?  It might be cleaner if we pipe the
enable and disable through the same mechanism.

[Ted C, 2013/11/26 19:24:29]

Agreed.

And EnableMediaAutoplay isn't exposed to java, which makes this feel unbalanced.

These methods should probably have more documentation to state that this is only
for the current renderer and subsequent navigations may clear this state.  Or if
we don't want that to be the case, we should be listening for render host
changes in this class and updating the prefs accordingly.

[apiccion, 2013/12/03 02:29:19]

Done.

+  virtual void EnableMediaAutoplay();
   virtual unsigned int GetScaledContentTexture(
       float scale,
       gfx::Size* out_size) OVERRIDE;
   virtual float GetDpiScale() const OVERRIDE;
   virtual void RequestContentClipping(const gfx::Rect& clipping,
                                       const gfx::Size& content_size) OVERRIDE;
   virtual void PauseVideo() OVERRIDE;
 
   // --------------------------------------------------------------------------
   // Methods called from Java via JNI
@@ skipping 277 matching lines @@
   void DeleteScaledSnapshotTexture();
 
   void SendGestureEvent(const blink::WebGestureEvent& event);
 
   // Update focus state of the RenderWidgetHostView.
   void SetFocusInternal(bool focused);
 
   // Send device_orientation_ to renderer.
   void SendOrientationChangeEventInternal();
 
+  // Update state of media autoplay.
+  void SetMediaAutoplayEnabled(bool isEnabled);

[David Trainor- moved to gerrit, 2013/11/26 18:59:32]

We could get rid of this if we piped through the other method.

[apiccion, 2013/12/03 02:29:19]

Done.

+
   // A weak reference to the Java ContentViewCore object.
   JavaObjectWeakGlobalRef java_ref_;
 
   NotificationRegistrar notification_registrar_;
 
   // Reference to the current WebContents used to determine how and what to
   // display in the ContentViewCore.
   WebContentsImpl* web_contents_;
 
   // A compositor layer containing any layer that should be shown.
@@ skipping 10 matching lines @@
   // like AutofillPopup.
   ui::ViewAndroid* view_android_;
 
   // The owning window that has a hold of main application activity.
   ui::WindowAndroid* window_android_;
 
   // The cache of device's current orientation set from Java side, this value
   // will be sent to Renderer once it is ready.
   int device_orientation_;
 
+  // Whether media autoplay is enabled for this content view.
+  bool is_media_autoplay_enabled_;
+
   DISALLOW_COPY_AND_ASSIGN(ContentViewCoreImpl);
 };
 
 bool RegisterContentViewCore(JNIEnv* env);
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_