Issue 864383002: Fix the PNaCl translator to lock the dump stream when printing errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 864383002: Fix the PNaCl translator to lock the dump stream when printing errors. (Closed)

Created:
5 years, 11 months ago by Karl

Modified:
5 years, 11 months ago

Reviewers:
jvoung (off chromium), Jim Stichnoth

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix the PNaCl translator to lock the dump stream when printing errors. The previous code did not do this. Also localizes the lock to when the error is actually printed. Note: requires https://codereview.chromium.org/865963002 BUG=None R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=819d7b56fe179db006d1c474b557230d8c8e5e2b

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -8 lines)			Patch
	M	src/PNaClTranslator.cpp	View		2 chunks	+5 lines, -8 lines	0 comments	Download

Total messages: 5 (2 generated)

Karl

5 years, 11 months ago (2015-01-22 18:00:17 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
819d7b56fe179db006d1c474b557230d8c8e5e2b (presubmit successful).