Issue 864343005: Revert of make getContentKey() available in GrGpuResource public interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 864343005: Revert of make getContentKey() available in GrGpuResource public interface (Closed)

Created:
5 years, 10 months ago by stephana

Modified:
5 years, 10 months ago

Reviewers:
bsalomon, robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of make getContentKey() available in GrGpuResource public interface (patchset #2 id:20001 of https://codereview.chromium.org/886313005/) Reason for revert: This causes in one case the linker and in the other the compiler to segfault. On Test-Ubuntu12-ShuttleA-GTX660-x86_64-Debug/Release Original issue's description: > make getContentKey() available in GrGpuResource public interface > > TBR=robertphillips@google.com > > Committed: https://skia.googlesource.com/skia/+/85ed2db092e75db41b711b9116a8d5b465fc2b0c TBR=robertphillips@google.com,bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/9b440260d54795213a13d6394b5c9546e0f69fae

Created: 5 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -16 lines)			Patch
M	include/gpu/GrGpuResource.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/gpu/GrGpuResourceCacheAccess.h	View	3 chunks	+7 lines, -2 lines	0 comments	Download
M	src/gpu/GrResourceCache2.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrResourceCache2.cpp	View	4 chunks	+9 lines, -9 lines	0 comments	Download

Total messages: 3 (0 generated)

stephana

Created Revert of make getContentKey() available in GrGpuResource public interface

5 years, 10 months ago (2015-02-02 22:51:41 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864343005/1

5 years, 10 months ago (2015-02-02 22:52:05 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-02 22:52:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9b440260d54795213a13d6394b5c9546e0f69fae