Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1613)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 864333004: Clean up DelegatedFrameHost's interface to its client (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More debugging over trybots, shoot menow Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc
index 432764d22a194df81312f362ead0fe287188994e..27cb755d27f54e03c77d82610d3f141f0b58927f 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -2583,32 +2583,35 @@ SkColorType RenderWidgetHostViewAura::PreferredReadbackFormat() {
////////////////////////////////////////////////////////////////////////////////
// DelegatedFrameHost, public:
-ui::Layer* RenderWidgetHostViewAura::GetLayer() {
+ui::Layer* RenderWidgetHostViewAura::DelegatedFrameHostGetLayer() const {
return window_->layer();
}
-RenderWidgetHostImpl* RenderWidgetHostViewAura::GetHost() {
- return host_;
-}
-
-bool RenderWidgetHostViewAura::IsVisible() {
- return IsShowing();
+bool RenderWidgetHostViewAura::DelegatedFrameHostIsVisible() const {
+ return !host_->is_hidden();
}
-gfx::Size RenderWidgetHostViewAura::DesiredFrameSize() {
+gfx::Size RenderWidgetHostViewAura::DelegatedFrameHostDesiredSizeInDIP() const {
return window_->bounds().size();
}
-float RenderWidgetHostViewAura::CurrentDeviceScaleFactor() {
- return current_device_scale_factor_;
-}
-
-gfx::Size RenderWidgetHostViewAura::ConvertViewSizeToPixel(
- const gfx::Size& size) {
- return content::ConvertViewSizeToPixel(this, size);
+bool RenderWidgetHostViewAura::DelegatedFrameCanCreateResizeLock() const {
+#if !defined(OS_CHROMEOS)
+ // On Windows and Linux, holding pointer moves will not help throttling
+ // resizes.
+ // TODO(piman): on Windows we need to block (nested message loop?) the
+ // WM_SIZE event. On Linux we need to throttle at the WM level using
+ // _NET_WM_SYNC_REQUEST.
+ return false;
+#else
+ if (host_->auto_resize_enabled())
+ return false;
+ return true;
+#endif
}
-scoped_ptr<ResizeLock> RenderWidgetHostViewAura::CreateResizeLock(
+scoped_ptr<ResizeLock>
+RenderWidgetHostViewAura::DelegatedFrameHostCreateResizeLock(
bool defer_compositor_lock) {
gfx::Size desired_size = window_->bounds().size();
return scoped_ptr<ResizeLock>(new CompositorResizeLock(
@@ -2618,8 +2621,32 @@ scoped_ptr<ResizeLock> RenderWidgetHostViewAura::CreateResizeLock(
base::TimeDelta::FromMilliseconds(kResizeLockTimeoutMs)));
}
-DelegatedFrameHost* RenderWidgetHostViewAura::GetDelegatedFrameHost() const {
- return delegated_frame_host_.get();
+void RenderWidgetHostViewAura::DelegatedFrameHostResizeLockWasReleased() {
+ host_->WasResized();
+}
+
+void RenderWidgetHostViewAura::DelegatedFrameHostSendCompositorSwapAck(
+ int output_surface_id,
+ const cc::CompositorFrameAck& ack) {
+ host_->Send(new ViewMsg_SwapCompositorFrameAck(host_->GetRoutingID(),
+ output_surface_id, ack));
+}
+
+void RenderWidgetHostViewAura::DelegatedFrameHostSendReclaimCompositorResources(
+ int output_surface_id,
+ const cc::CompositorFrameAck& ack) {
+ host_->Send(new ViewMsg_ReclaimCompositorResources(host_->GetRoutingID(),
+ output_surface_id, ack));
+}
+
+void RenderWidgetHostViewAura::DelegatedFrameHostOnLostCompositorResources() {
+ host_->ScheduleComposite();
+}
+
+void RenderWidgetHostViewAura::DelegatedFrameHostUpdateVSyncParameters(
+ const base::TimeTicks& timebase,
+ const base::TimeDelta& interval) {
+ host_->UpdateVSyncParameters(timebase, interval);
}
////////////////////////////////////////////////////////////////////////////////

Powered by Google App Engine
This is Rietveld 408576698