Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 864333004: Clean up DelegatedFrameHost's interface to its client (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorprate review feedback Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_mac.mm
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm
index fa3850a20fbb878714a55769ac7021f2a79bf27f..cf4fdbe8700c4fd993ba6c385813a4c6103ca625 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.mm
+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm
@@ -394,41 +394,52 @@ namespace content {
////////////////////////////////////////////////////////////////////////////////
// DelegatedFrameHost, public:
-ui::Layer* RenderWidgetHostViewMac::GetLayer() {
- return root_layer_.get();
+bool RenderWidgetHostViewMac::DelegatedFrameHostIsVisible() const {
+ return !render_widget_host_->is_hidden();
}
-RenderWidgetHostImpl* RenderWidgetHostViewMac::GetHost() {
- return render_widget_host_;
+gfx::Size RenderWidgetHostViewMac::DelegatedFrameHostDesiredSizeInDIP() const {
+ return GetViewBounds().size();
}
-bool RenderWidgetHostViewMac::IsVisible() {
- return !render_widget_host_->is_hidden();
+bool RenderWidgetHostViewMac::DelegatedFrameCanCreateResizeLock() const {
+ // Mac uses the RenderWidgetResizeHelper instead of a resize lock.
+ return false;
}
-gfx::Size RenderWidgetHostViewMac::DesiredFrameSize() {
- return GetViewBounds().size();
+scoped_ptr<ResizeLock>
+RenderWidgetHostViewMac::DelegatedFrameHostCreateResizeLock(
+ bool defer_compositor_lock) {
+ NOTREACHED();
+ return scoped_ptr<ResizeLock>();
}
-float RenderWidgetHostViewMac::CurrentDeviceScaleFactor() {
- return ViewScaleFactor();
+void RenderWidgetHostViewMac::DelegatedFrameHostResizeLockWasReleased() {
+ NOTREACHED();
}
-gfx::Size RenderWidgetHostViewMac::ConvertViewSizeToPixel(
- const gfx::Size& size) {
- return gfx::ToEnclosingRect(gfx::ScaleRect(gfx::Rect(size),
- ViewScaleFactor())).size();
+void RenderWidgetHostViewMac::DelegatedFrameHostSendCompositorSwapAck(
+ int output_surface_id,
+ const cc::CompositorFrameAck& ack) {
+ render_widget_host_->Send(new ViewMsg_SwapCompositorFrameAck(
+ render_widget_host_->GetRoutingID(), output_surface_id, ack));
}
-scoped_ptr<ResizeLock> RenderWidgetHostViewMac::CreateResizeLock(
- bool defer_compositor_lock) {
- NOTREACHED();
- ResizeLock* lock = NULL;
- return scoped_ptr<ResizeLock>(lock);
+void RenderWidgetHostViewMac::DelegatedFrameHostSendReclaimCompositorResources(
+ int output_surface_id,
+ const cc::CompositorFrameAck& ack) {
+ render_widget_host_->Send(new ViewMsg_ReclaimCompositorResources(
+ render_widget_host_->GetRoutingID(), output_surface_id, ack));
}
-DelegatedFrameHost* RenderWidgetHostViewMac::GetDelegatedFrameHost() const {
- return delegated_frame_host_.get();
+void RenderWidgetHostViewMac::DelegatedFrameHostOnLostCompositorResources() {
+ render_widget_host_->ScheduleComposite();
+}
+
+void RenderWidgetHostViewMac::DelegatedFrameHostUpdateVSyncParameters(
+ const base::TimeTicks& timebase,
+ const base::TimeDelta& interval) {
+ render_widget_host_->UpdateVSyncParameters(timebase, interval);
}
////////////////////////////////////////////////////////////////////////////////
@@ -537,7 +548,8 @@ RenderWidgetHostViewMac::RenderWidgetHostViewMac(RenderWidgetHost* widget,
if (IsDelegatedRendererEnabled()) {
root_layer_.reset(new ui::Layer(ui::LAYER_SOLID_COLOR));
- delegated_frame_host_.reset(new DelegatedFrameHost(this));
+ delegated_frame_host_.reset(
+ new DelegatedFrameHost(this, root_layer_.get()));
}
gfx::Screen::GetScreenFor(cocoa_view_)->AddObserver(this);
@@ -814,7 +826,6 @@ RenderWidgetHost* RenderWidgetHostViewMac::GetRenderWidgetHost() const {
return render_widget_host_;
}
-
void RenderWidgetHostViewMac::Show() {
[cocoa_view_ setHidden:NO];
if (!render_widget_host_->is_hidden())
@@ -2551,7 +2562,8 @@ void RenderWidgetHostViewMac::OnDisplayMetricsChanged(
- (id)accessibilityAttributeValue:(NSString *)attribute {
BrowserAccessibilityManager* manager =
- renderWidgetHostView_->GetHost()->GetRootBrowserAccessibilityManager();
+ renderWidgetHostView_->render_widget_host_
+ ->GetRootBrowserAccessibilityManager();
// Contents specifies document view of RenderWidgetHostViewCocoa provided by
// BrowserAccessibilityManager. Children includes all subviews in addition to
@@ -2577,7 +2589,8 @@ void RenderWidgetHostViewMac::OnDisplayMetricsChanged(
- (id)accessibilityHitTest:(NSPoint)point {
BrowserAccessibilityManager* manager =
- renderWidgetHostView_->GetHost()->GetRootBrowserAccessibilityManager();
+ renderWidgetHostView_->render_widget_host_
+ ->GetRootBrowserAccessibilityManager();
if (!manager)
return self;
NSPoint pointInWindow = [[self window] convertScreenToBase:point];
@@ -2591,13 +2604,15 @@ void RenderWidgetHostViewMac::OnDisplayMetricsChanged(
- (BOOL)accessibilityIsIgnored {
BrowserAccessibilityManager* manager =
- renderWidgetHostView_->GetHost()->GetRootBrowserAccessibilityManager();
+ renderWidgetHostView_->render_widget_host_
+ ->GetRootBrowserAccessibilityManager();
return !manager;
}
- (NSUInteger)accessibilityGetIndexOf:(id)child {
BrowserAccessibilityManager* manager =
- renderWidgetHostView_->GetHost()->GetRootBrowserAccessibilityManager();
+ renderWidgetHostView_->render_widget_host_
+ ->GetRootBrowserAccessibilityManager();
// Only child is root.
if (manager &&
manager->GetRoot()->ToBrowserAccessibilityCocoa() == child) {
@@ -2609,7 +2624,8 @@ void RenderWidgetHostViewMac::OnDisplayMetricsChanged(
- (id)accessibilityFocusedUIElement {
BrowserAccessibilityManager* manager =
- renderWidgetHostView_->GetHost()->GetRootBrowserAccessibilityManager();
+ renderWidgetHostView_->render_widget_host_
+ ->GetRootBrowserAccessibilityManager();
if (manager) {
BrowserAccessibility* focused_item = manager->GetFocus(NULL);
DCHECK(focused_item);

Powered by Google App Engine
This is Rietveld 408576698