Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

Issue 864333004: Clean up DelegatedFrameHost's interface to its client (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorprate review feedback Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
index b39f5bdadf8feb5f2f6da07ee0f4a8dbcd2d0548..bfe9ab245de2380d84e6191a6dcd462802718bbf 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
@@ -217,22 +217,21 @@ class FakeRenderWidgetHostViewAura : public RenderWidgetHostViewAura {
~FakeRenderWidgetHostViewAura() override {}
- scoped_ptr<ResizeLock> CreateResizeLock(bool defer_compositor_lock) override {
+ scoped_ptr<ResizeLock> DelegatedFrameHostCreateResizeLock(
+ bool defer_compositor_lock) override {
gfx::Size desired_size = window()->bounds().size();
return scoped_ptr<ResizeLock>(
new FakeResizeLock(desired_size, defer_compositor_lock));
}
+ bool DelegatedFrameCanCreateResizeLock() const override { return true; }
+
void RunOnCompositingDidCommit() {
GetDelegatedFrameHost()->OnCompositingDidCommitForTesting(
window()->GetHost()->compositor());
}
- bool ShouldCreateResizeLock() override {
- return GetDelegatedFrameHost()->ShouldCreateResizeLockForTesting();
- }
-
- void RequestCopyOfOutput(scoped_ptr<cc::CopyOutputRequest> request) override {
+ void InterceptCopyOfOutput(scoped_ptr<cc::CopyOutputRequest> request) {
last_copy_request_ = request.Pass();
if (last_copy_request_->has_texture_mailbox()) {
// Give the resulting texture a size.
@@ -1143,6 +1142,7 @@ TEST_F(RenderWidgetHostViewAuraTest, TouchEventSyncAsync) {
TEST_F(RenderWidgetHostViewAuraTest, PhysicalBackingSizeWithScale) {
view_->InitAsChild(NULL);
+
aura::client::ParentWindowWithContext(
view_->GetNativeView(),
parent_view_->GetNativeView()->GetRootWindow(),
@@ -2042,6 +2042,9 @@ TEST_F(RenderWidgetHostViewAuraCopyRequestTest, DestroyedAfterCopyRequest) {
scoped_ptr<cc::CopyOutputRequest> request;
view_->InitAsChild(NULL);
+ view_->GetDelegatedFrameHost()->SetRequestCopyOfOutputCallbackForTesting(
+ base::Bind(&FakeRenderWidgetHostViewAura::InterceptCopyOfOutput,
+ base::Unretained(view_)));
aura::client::ParentWindowWithContext(
view_->GetNativeView(),
parent_view_->GetNativeView()->GetRootWindow(),

Powered by Google App Engine
This is Rietveld 408576698