Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 864333002: Rewrote fast/multicol/span/anonymous-style-inheritance.html to a check-layout test. (Closed)

Created:
5 years, 11 months ago by mstensho (USE GERRIT)
Modified:
5 years, 11 months ago
Reviewers:
andersr
CC:
mstensho (USE GERRIT), blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rewrote fast/multicol/span/anonymous-style-inheritance.html to a check-layout test. Also renamed it. The only useful thing this did test, taking existing tests into consideration, was to make sure that margins on a multicol don't collapse with those of a spanner. BUG=386567 R=andersr@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189016

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -293 lines) Patch
M LayoutTests/TestExpectations View 2 chunks +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/multicol/span/anonymous-style-inheritance.html View 1 chunk +0 lines, -30 lines 0 comments Download
A LayoutTests/fast/multicol/span/margin-on-multicol.html View 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/span/margin-on-multicol-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
D LayoutTests/platform/android/fast/multicol/span/anonymous-style-inheritance-expected.txt View 1 chunk +0 lines, -53 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/span/anonymous-style-inheritance-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/multicol/span/anonymous-style-inheritance-expected.txt View 1 chunk +0 lines, -53 lines 0 comments Download
D LayoutTests/platform/mac/fast/multicol/span/anonymous-style-inheritance-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/span/anonymous-style-inheritance-expected.txt View 1 chunk +0 lines, -52 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/span/anonymous-style-inheritance-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/span/anonymous-style-inheritance-expected.txt View 1 chunk +0 lines, -51 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/span/anonymous-style-inheritance-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/span/anonymous-style-inheritance-expected.txt View 1 chunk +0 lines, -52 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 11 months ago (2015-01-26 12:54:25 UTC) #1
andersr
lgtm
5 years, 11 months ago (2015-01-27 09:46:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864333002/1
5 years, 11 months ago (2015-01-27 09:52:00 UTC) #4
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 09:55:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189016

Powered by Google App Engine
This is Rietveld 408576698