Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 864323002: Move NDK gyp file from third_party/android_tools. (Closed)

Created:
5 years, 11 months ago by Fabrice (no longer in Chrome)
Modified:
5 years, 10 months ago
Reviewers:
pasko, scottmg
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move NDK gyp file from third_party/android_tools. BUG=428426 Committed: https://crrev.com/dce75c43ab1c93e89cf8fb98a51949a8225a3816 Cr-Commit-Position: refs/heads/master@{#313269}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1

Patch Set 3 : changing year is hard #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M build/android/cpufeatures.gypi View 1 chunk +1 line, -1 line 0 comments Download
A + build/android/ndk.gyp View 1 2 1 chunk +6 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Fabrice (no longer in Chrome)
PTAL This is the only reference to that file. I am moving it out of ...
5 years, 10 months ago (2015-01-26 11:49:25 UTC) #2
pasko
lgtm, thank you https://codereview.chromium.org/864323002/diff/20001/build/android/ndk.gyp File build/android/ndk.gyp (right): https://codereview.chromium.org/864323002/diff/20001/build/android/ndk.gyp#newcode1 build/android/ndk.gyp:1: # Copyright (c) 2014 The Chromium ...
5 years, 10 months ago (2015-01-26 11:52:35 UTC) #3
scottmg
rs lgtm
5 years, 10 months ago (2015-01-26 17:26:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864323002/40001
5 years, 10 months ago (2015-01-27 12:43:40 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-01-27 13:42:27 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-01-27 13:43:27 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dce75c43ab1c93e89cf8fb98a51949a8225a3816
Cr-Commit-Position: refs/heads/master@{#313269}

Powered by Google App Engine
This is Rietveld 408576698