pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart - Issue 864293004: Add a shrinking reduction for dead continuation parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart

Issue 864293004: Add a shrinking reduction for dead continuation parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart ('K') | « pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart ('k') | pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart » ('j') | pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart

diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart

index 8c8183224abd29980f97a82ca2ff3789c0ebbcd0..bdafde886a4cf6f04c112c65dd4fdacbab3e065e 100644

--- a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart

+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart

@@ -158,11 +158,10 @@ class SExpressionStringifier extends Visitor<String> with Indentation {

}

String visitInvokeContinuation(InvokeContinuation node) {

- String cont = access(node.continuation);

+ String name = access(node.continuation);

+ if (node.isRecursive) name = 'rec $name';

String args = node.arguments.map(access).join(' ');

- String op =

- node.isRecursive ? 'InvokeContinuation*' : 'InvokeContinuation';

- return '$indentation($op $cont ($args))';

+ return '$indentation($InvokeContinuation $name ($args))';

}

String visitBranch(Branch node) {