test/cctest/test-parsing.cc - Issue 864273005: Scanner / Unicode decoding: use size_t instead of unsigned.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-parsing.cc

Issue 864273005: Scanner / Unicode decoding: use size_t instead of unsigned. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: tentative Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-parsing.cc

diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc

index 8018bae88e0f41b4607a95ef60b0b3b6250f40bb..7630dcd1a57517ff1fbb0969849d917447f411f4 100644

--- a/test/cctest/test-parsing.cc

+++ b/test/cctest/test-parsing.cc

@@ -696,7 +696,7 @@ TEST(Utf8CharacterStream) {

int i = 0;

while (stream.pos() < kMaxUC16CharU) {

CHECK_EQU(i, stream.pos());

- unsigned progress = stream.SeekForward(12);

+ int progress = static_cast<int>(stream.SeekForward(12));

i += progress;

int32_t c = stream.Advance();

if (i <= kMaxUC16Char) {

« no previous file with comments | « src/utils.h ('k') | no next file » | no next file with comments »