src/heap-snapshot-generator.cc - Issue 864273005: Scanner / Unicode decoding: use size_t instead of unsigned.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap-snapshot-generator.cc

Issue 864273005: Scanner / Unicode decoding: use size_t instead of unsigned. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: tentative Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap-snapshot-generator.cc

diff --git a/src/heap-snapshot-generator.cc b/src/heap-snapshot-generator.cc

index ad6536e3580921add872e3b4fa17c6c3ae151c5b..8e185184cea3c6b5a9aca3af727b92cc0fac975a 100644

--- a/src/heap-snapshot-generator.cc

+++ b/src/heap-snapshot-generator.cc

@@ -3102,7 +3102,7 @@ void HeapSnapshotJSONSerializer::SerializeString(const unsigned char* s) {

WriteUChar(writer_, *s);

} else {

// Convert UTF-8 into \u UTF-16 literal.

- unsigned length = 1, cursor = 0;

+ size_t length = 1, cursor = 0;

for ( ; length <= 4 && *(s + length) != '\0'; ++length) { }

unibrow::uchar c = unibrow::Utf8::CalculateValue(s, length, &cursor);

if (c != unibrow::Utf8::kBadChar) {

« no previous file with comments | « src/factory.cc ('k') | src/heap/heap.cc » ('j') | no next file with comments »