Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 864273005: Scanner / Unicode decoding: use size_t instead of unsigned. (Closed)

Created:
5 years, 10 months ago by marja
Modified:
5 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Scanner / Unicode decoding: use size_t instead of unsigned. size_t is the correct data type for this purpose. Our APIs (in particular ExternalSourceStream::GetMoreData) are already using it, and there were some static_casts to convert between them. This CL doesn't intend to fix all of V8, just the minimal sense-making part around scanner character streams. BUG= Committed: https://crrev.com/0e3b5386aec539599c241bac09a25a8b5d2a4ef5 Cr-Commit-Position: refs/heads/master@{#26449}

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : fixes #

Patch Set 4 : fixes #

Patch Set 5 : tentative #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -154 lines) Patch
M src/factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M src/scanner.h View 1 2 3 4 3 chunks +6 lines, -7 lines 0 comments Download
M src/scanner-character-streams.h View 5 chunks +26 lines, -27 lines 0 comments Download
M src/scanner-character-streams.cc View 1 2 20 chunks +41 lines, -46 lines 0 comments Download
M src/unicode.h View 2 chunks +2 lines, -6 lines 0 comments Download
M src/unicode.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/unicode-decoder.h View 2 chunks +22 lines, -23 lines 0 comments Download
M src/unicode-decoder.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/unicode-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/utils.h View 1 11 chunks +28 lines, -26 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
marja
svenpanne, ptal. This is an old-ish problem, this CL is trying to make the API ...
5 years, 10 months ago (2015-02-04 13:51:25 UTC) #2
Sven Panne
lgtm
5 years, 10 months ago (2015-02-05 07:52:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864273005/80001
5 years, 10 months ago (2015-02-05 07:52:49 UTC) #5
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-02-05 07:54:33 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 07:54:46 UTC) #7
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/0e3b5386aec539599c241bac09a25a8b5d2a4ef5
Cr-Commit-Position: refs/heads/master@{#26449}

Powered by Google App Engine
This is Rietveld 408576698