Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 864273003: Revert of Profiler-instrumentation of the startup time (Closed)

Created:
5 years, 10 months ago by oystein (OOO til 10th of July)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, gab
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Profiler-instrumentation of the startup time (patchset #2 id:20001 of https://codereview.chromium.org/866403008/) Reason for revert: Reverting due to https://crbug.com/454534 Original issue's description: > Profiler-instrumentation of the startup time. > > Before the instrumentation, startup time wasn't reported in profiler data. > > Profiling it will allow the genre of detailed analysis of the startup time via jankiness investigations. > > This change requires temporarily initializing tracking earlier than usual. Thie will either removed once the investigations complete, or will be officially converted to permanent code. > > BUG=453640 > > Committed: https://crrev.com/1ebb11710e08d51fa99836190edc3db28dffc136 > Cr-Commit-Position: refs/heads/master@{#314179} TBR=asvitkine@chromium.org,isherman@chromium.org,cpu@chromium.org,vadimt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=453640 Committed: https://crrev.com/08e8ca85abb7216e00ebdd957287274c8880aeba Cr-Commit-Position: refs/heads/master@{#314204}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M chrome/app/chrome_main.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M content/browser/browser_main_runner.cc View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
oystein (OOO til 10th of July)
Created Revert of Profiler-instrumentation of the startup time
5 years, 10 months ago (2015-02-02 22:38:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864273003/1
5 years, 10 months ago (2015-02-02 22:40:25 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
5 years, 10 months ago (2015-02-02 22:41:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-02 22:41:40 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 22:42:46 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08e8ca85abb7216e00ebdd957287274c8880aeba
Cr-Commit-Position: refs/heads/master@{#314204}

Powered by Google App Engine
This is Rietveld 408576698