Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Issue 864273002: Call directly to c callbacks in Invoke instead of transitioning to js and back out. (Closed)

Created:
5 years, 11 months ago by dcarney
Modified:
5 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Call directly to c callbacks in Invoke instead of transitioning to js and back out. BUG= Committed: https://crrev.com/ce457e2b596c3ccf5bf454eeed0969f3f3efd174 Cr-Commit-Position: refs/heads/master@{#26231}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -19 lines) Patch
M src/builtins.h View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -0 lines 0 comments Download
M src/builtins.cc View 1 2 3 4 5 6 7 8 4 chunks +61 lines, -19 lines 0 comments Download
M src/execution.cc View 1 2 3 4 5 6 7 8 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Toon Verwaest
lgtm
5 years, 11 months ago (2015-01-22 12:32:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864273002/150001
5 years, 11 months ago (2015-01-22 21:09:34 UTC) #4
commit-bot: I haz the power
Committed patchset #9 (id:150001)
5 years, 11 months ago (2015-01-22 21:37:12 UTC) #5
commit-bot: I haz the power
Patchset 9 (id:??) landed as https://crrev.com/ce457e2b596c3ccf5bf454eeed0969f3f3efd174 Cr-Commit-Position: refs/heads/master@{#26231}
5 years, 11 months ago (2015-01-22 21:37:27 UTC) #6
Michael Achenbach
Looks like this causes lots of flakes in cctest/test-api/Threading4
5 years, 11 months ago (2015-01-23 07:14:36 UTC) #7
dcarney
5 years, 11 months ago (2015-01-23 08:53:12 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #9 id:150001) has been created in
https://codereview.chromium.org/873583003/ by dcarney@chromium.org.

The reason for reverting is: threading4 flakiness.

Powered by Google App Engine
This is Rietveld 408576698