Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 864173009: Add paper-dropdown and paper-dropdown-menu and run reproduce.sh (Closed)

Created:
5 years, 10 months ago by Jeremy Klein
Modified:
5 years, 10 months ago
CC:
chromium-reviews, dcheng, michaelpg+watch-polymer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add paper-dropdown and paper-dropdown-menu and run reproduce.sh R=dzhioev@chromium.org BUG= Committed: https://crrev.com/150281d62a5fc771503d45a00746c62c7bb31535 Cr-Commit-Position: refs/heads/master@{#317235}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Force git add components and components-chromium to pick up new directories" #

Patch Set 3 : Add necessary resources to polymer_resources.grdp #

Patch Set 4 : Serve only necessary files. #

Patch Set 5 : Rebase to isolate paper-dropdown change #

Patch Set 6 : Fix rebase #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1236 lines, -365 lines) Patch
M third_party/polymer/README.chromium View 1 2 3 4 5 6 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/polymer/bower.json View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/polymer/components-chromium/paper-dropdown-menu/.bower.json View 1 2 3 4 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/polymer/components-chromium/paper-dropdown-menu/README.md View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
A + third_party/polymer/components-chromium/paper-dropdown-menu/bower.json View 1 2 3 4 5 6 1 chunk +5 lines, -8 lines 0 comments Download
A + third_party/polymer/components-chromium/paper-dropdown-menu/demo.html View 1 2 3 4 5 6 6 chunks +65 lines, -45 lines 0 comments Download
A + third_party/polymer/components-chromium/paper-dropdown-menu/index.html View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/polymer/components-chromium/paper-dropdown-menu/paper-dropdown-menu.css View 1 2 3 4 1 chunk +23 lines, -20 lines 0 comments Download
A third_party/polymer/components-chromium/paper-dropdown-menu/paper-dropdown-menu.html View 1 2 3 4 1 chunk +112 lines, -0 lines 0 comments Download
A + third_party/polymer/components-chromium/paper-dropdown-menu/paper-dropdown-menu-extracted.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + third_party/polymer/components-chromium/paper-dropdown-menu/test/basic.html View 1 2 3 4 6 chunks +12 lines, -59 lines 0 comments Download
A third_party/polymer/components-chromium/paper-dropdown/.bower.json View 1 2 3 4 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/polymer/components-chromium/paper-dropdown/README.md View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/polymer/components-chromium/paper-dropdown/bower.json View 1 2 3 4 1 chunk +19 lines, -0 lines 0 comments Download
A + third_party/polymer/components-chromium/paper-dropdown/demo.html View 1 2 3 4 7 chunks +40 lines, -24 lines 0 comments Download
A + third_party/polymer/components-chromium/paper-dropdown/index.html View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A third_party/polymer/components-chromium/paper-dropdown/paper-dropdown.html View 1 2 3 4 1 chunk +98 lines, -0 lines 0 comments Download
A third_party/polymer/components-chromium/paper-dropdown/paper-dropdown-extracted.js View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download
A + third_party/polymer/components-chromium/paper-dropdown/paper-dropdown-transition.css View 1 2 3 4 1 chunk +7 lines, -8 lines 0 comments Download
A + third_party/polymer/components-chromium/paper-dropdown/paper-dropdown-transition.html View 1 2 3 4 1 chunk +13 lines, -12 lines 0 comments Download
A third_party/polymer/components-chromium/paper-dropdown/paper-dropdown-transition-extracted.js View 1 2 3 4 1 chunk +135 lines, -0 lines 0 comments Download
A third_party/polymer/components/paper-dropdown-menu/.bower.json View 1 2 3 4 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/polymer/components/paper-dropdown-menu/README.md View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
A + third_party/polymer/components/paper-dropdown-menu/bower.json View 1 2 3 4 5 6 1 chunk +5 lines, -8 lines 0 comments Download
A + third_party/polymer/components/paper-dropdown-menu/demo.html View 1 2 3 4 5 6 6 chunks +65 lines, -45 lines 0 comments Download
A + third_party/polymer/components/paper-dropdown-menu/index.html View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/polymer/components/paper-dropdown-menu/paper-dropdown-menu.css View 1 2 3 4 1 chunk +23 lines, -20 lines 0 comments Download
A + third_party/polymer/components/paper-dropdown-menu/paper-dropdown-menu.html View 1 2 3 4 1 chunk +61 lines, -21 lines 0 comments Download
A + third_party/polymer/components/paper-dropdown-menu/test/basic.html View 1 2 3 4 6 chunks +12 lines, -59 lines 0 comments Download
A third_party/polymer/components/paper-dropdown/.bower.json View 1 2 3 4 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/polymer/components/paper-dropdown/README.md View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/polymer/components/paper-dropdown/bower.json View 1 2 3 4 1 chunk +19 lines, -0 lines 0 comments Download
A + third_party/polymer/components/paper-dropdown/demo.html View 1 2 3 4 7 chunks +40 lines, -24 lines 0 comments Download
A + third_party/polymer/components/paper-dropdown/index.html View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A third_party/polymer/components/paper-dropdown/paper-dropdown.html View 1 2 3 4 1 chunk +117 lines, -0 lines 0 comments Download
A + third_party/polymer/components/paper-dropdown/paper-dropdown-transition.css View 1 2 3 4 1 chunk +7 lines, -8 lines 0 comments Download
A third_party/polymer/components/paper-dropdown/paper-dropdown-transition.html View 1 2 3 4 1 chunk +166 lines, -0 lines 0 comments Download
M ui/webui/resources/polymer_resources.grdp View 1 2 3 4 5 6 2 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
Jeremy Klein
5 years, 10 months ago (2015-02-09 23:27:26 UTC) #1
Jeremy Klein
Note that most of the files changed in this CL are just due to the ...
5 years, 10 months ago (2015-02-09 23:34:27 UTC) #2
michaelpg
did you forget to "git add -f" paper-dropdown and paper-dropdown-menu in components and component-chromium? https://codereview.chromium.org/864173009/diff/1/third_party/polymer/bower.json ...
5 years, 10 months ago (2015-02-09 23:35:25 UTC) #4
Jeremy Klein
Note: web-animations-js/test/* is huge. Would it be ok to remove it in reproduce.sh?
5 years, 10 months ago (2015-02-10 04:47:48 UTC) #6
michaelpg
Yeah, if it's just a test suite for web-animations-js itself, I think that's a reasonable ...
5 years, 10 months ago (2015-02-10 05:47:07 UTC) #7
dzhioev (left Google)
On 2015/02/09 23:27:26, Jeremy Klein wrote: Hello Jeremy, the things are harder than they look. ...
5 years, 10 months ago (2015-02-10 10:14:05 UTC) #8
Jeremy Klein
On 2015/02/10 10:14:05, dzhioev wrote: > On 2015/02/09 23:27:26, Jeremy Klein wrote: > > Hello ...
5 years, 10 months ago (2015-02-10 19:33:21 UTC) #9
Jeremy Klein
This should be fully up-to-date now. Did you guys have any comments on this that ...
5 years, 10 months ago (2015-02-17 23:31:16 UTC) #10
michaelpg
lgtm
5 years, 10 months ago (2015-02-19 00:06:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864173009/90001
5 years, 10 months ago (2015-02-20 01:46:48 UTC) #15
commit-bot: I haz the power
Committed patchset #7 (id:90001)
5 years, 10 months ago (2015-02-20 04:05:26 UTC) #16
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 04:06:21 UTC) #17
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/150281d62a5fc771503d45a00746c62c7bb31535
Cr-Commit-Position: refs/heads/master@{#317235}

Powered by Google App Engine
This is Rietveld 408576698