Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(857)

Issue 864173006: Add GN build support for Android 64-bit platforms. (Closed)

Created:
5 years, 10 months ago by haltonhuo
Modified:
5 years, 10 months ago
Reviewers:
brettw, qsr, blundell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add GN build support for Android 64-bit platforms. gn now run with arg target_arch = "x64", arm64 and mips64el releated changes are added as well but not verified. BUG=none Committed: https://crrev.com/98de73d11797b1b0ac7ac0b2f4234cb8f57bd2fc Cr-Commit-Position: refs/heads/master@{#315680}

Patch Set 1 #

Patch Set 2 : Remove mojo string in log #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
M build/config/android/config.gni View 4 chunks +31 lines, -0 lines 0 comments Download
M build/config/sysroot.gni View 1 chunk +6 lines, -0 lines 0 comments Download
M build/toolchain/android/BUILD.gn View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
haltonhuo
This CL is original submitted for mojo project, but truns out I should do in ...
5 years, 10 months ago (2015-02-09 09:17:01 UTC) #2
qsr
Remove mojob comment in the description. This is a mojo specific tool.
5 years, 10 months ago (2015-02-09 09:35:27 UTC) #3
haltonhuo
On 2015/02/09 09:35:27, qsr wrote: > Remove mojob comment in the description. This is a ...
5 years, 10 months ago (2015-02-09 09:40:37 UTC) #4
qsr
LGTM
5 years, 10 months ago (2015-02-09 09:47:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864173006/20001
5 years, 10 months ago (2015-02-09 09:49:12 UTC) #7
qsr
On 2015/02/09 09:49:12, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 10 months ago (2015-02-09 09:51:20 UTC) #8
haltonhuo
On 2015/02/09 09:51:20, qsr wrote: > On 2015/02/09 09:49:12, I haz the power (commit-bot) wrote: ...
5 years, 10 months ago (2015-02-09 09:53:04 UTC) #9
qsr
On 2015/02/09 09:53:04, haltonhuo wrote: > On 2015/02/09 09:51:20, qsr wrote: > > On 2015/02/09 ...
5 years, 10 months ago (2015-02-09 09:54:32 UTC) #11
brettw
lgtm
5 years, 10 months ago (2015-02-10 22:52:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864173006/20001
5 years, 10 months ago (2015-02-11 00:02:44 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-11 00:08:40 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 00:09:27 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/98de73d11797b1b0ac7ac0b2f4234cb8f57bd2fc
Cr-Commit-Position: refs/heads/master@{#315680}

Powered by Google App Engine
This is Rietveld 408576698