Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 86413004: Notify the client of a document access even if document.write is used. (Closed)

Created:
7 years ago by Charlie Reis
Modified:
7 years ago
CC:
Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Notify the client of a document access even if document.write is used. Modal dialogs can usually delay the notification from reaching the client. notifyIfInitialDocumentAccessed is used to skip the timer if a dialog is shown (via PageGroupLoadDeferrer), but it shouldn't care whether the FrameLoader is still in the initial empty document state. BUG=322959 TEST=See bug for repro steps. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162673

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
M Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Charlie Reis
Darin, can you take a look? I think we just need to check whether the ...
7 years ago (2013-11-25 23:49:51 UTC) #1
darin (slow to review)
Makes sense. LGTM
7 years ago (2013-11-26 05:21:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/86413004/1
7 years ago (2013-11-26 05:36:45 UTC) #3
commit-bot: I haz the power
7 years ago (2013-11-26 07:04:52 UTC) #4
Message was sent while issue was closed.
Change committed as 162673

Powered by Google App Engine
This is Rietveld 408576698