Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionEngine.java

Issue 86413003: Issue 10693. Fix for displaying constructor documentation in code completion. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionEngine.java
diff --git a/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionEngine.java b/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionEngine.java
index fcb737ee73188650b0e004882fed591a59e20edf..e30f42ee234cc033812b80dca24361156a4a6cd9 100644
--- a/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionEngine.java
+++ b/editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/completion/CompletionEngine.java
@@ -2153,6 +2153,7 @@ public class CompletionEngine {
private CompletionProposal createProposal(Element element, String completion) {
ProposalKind kind = proposalKindOf(element);
CompletionProposal prop = createProposal(kind);
+ prop.setElement(element);
prop.setCompletion(completion);
prop.setDeprecated(isDeprecated(element));
if (isPrivate(element)) {
@@ -2421,7 +2422,6 @@ public class CompletionEngine {
setParameterInfo(element, prop);
prop.setCompletion(name).setReturnType(element.getType().getReturnType().getDisplayName());
- prop.setElement(element);
// If there is already argument list, then update only method name.
if (identifier.getParent() instanceof MethodInvocation
@@ -2444,7 +2444,6 @@ public class CompletionEngine {
return; // Simple constructors are not handled here
}
CompletionProposal prop = createProposal(element);
- prop.setElement(element);
if (element.getType() != null) {
prop.setReturnType(element.getType().getName());
}
@@ -2468,7 +2467,6 @@ public class CompletionEngine {
return;
}
CompletionProposal prop = createProposal(element);
- prop.setElement(element);
Element container = element.getEnclosingElement();
prop.setDeclaringType(container.getDisplayName());
requestor.accept(prop);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698