Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 864113002: Pepper: PPB_VideoDecoder software fallback should support all YUV formats. (Closed)

Created:
5 years, 11 months ago by bbudge
Modified:
5 years, 10 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pepper: PPB_VideoDecoder software fallback should support all YUV formats. Modifies media/filters/skcanvas_video_renderer to expose its utility method to convert YUV VideoFrames to RGB. BUG=450205 Committed: https://crrev.com/7081c5b0d4e517dfbb29bdf8c357d0f938a7dc57 Cr-Commit-Position: refs/heads/master@{#313332}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Total comments: 2

Patch Set 4 : Remove unneeded #include. #

Patch Set 5 : Rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -161 lines) Patch
M content/renderer/pepper/video_decoder_shim.cc View 1 2 3 4 2 chunks +5 lines, -11 lines 2 comments Download
M media/filters/skcanvas_video_renderer.h View 1 chunk +8 lines, -0 lines 0 comments Download
M media/filters/skcanvas_video_renderer.cc View 1 2 3 chunks +151 lines, -150 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
bbudge
5 years, 11 months ago (2015-01-27 14:35:50 UTC) #2
sandersd (OOO until July 31)
lgtm https://codereview.chromium.org/864113002/diff/40001/content/renderer/pepper/video_decoder_shim.cc File content/renderer/pepper/video_decoder_shim.cc (right): https://codereview.chromium.org/864113002/diff/40001/content/renderer/pepper/video_decoder_shim.cc#newcode27 content/renderer/pepper/video_decoder_shim.cc:27: #include "third_party/libyuv/include/libyuv.h" Remove?
5 years, 11 months ago (2015-01-27 18:16:45 UTC) #3
bbudge
https://codereview.chromium.org/864113002/diff/40001/content/renderer/pepper/video_decoder_shim.cc File content/renderer/pepper/video_decoder_shim.cc (right): https://codereview.chromium.org/864113002/diff/40001/content/renderer/pepper/video_decoder_shim.cc#newcode27 content/renderer/pepper/video_decoder_shim.cc:27: #include "third_party/libyuv/include/libyuv.h" On 2015/01/27 18:16:45, sandersd wrote: > Remove? ...
5 years, 11 months ago (2015-01-27 18:23:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864113002/80001
5 years, 11 months ago (2015-01-27 18:59:32 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 11 months ago (2015-01-27 20:00:26 UTC) #7
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/7081c5b0d4e517dfbb29bdf8c357d0f938a7dc57 Cr-Commit-Position: refs/heads/master@{#313332}
5 years, 11 months ago (2015-01-27 20:02:41 UTC) #8
dshwang
https://codereview.chromium.org/864113002/diff/80001/content/renderer/pepper/video_decoder_shim.cc File content/renderer/pepper/video_decoder_shim.cc (right): https://codereview.chromium.org/864113002/diff/80001/content/renderer/pepper/video_decoder_shim.cc#newcode274 content/renderer/pepper/video_decoder_shim.cc:274: // Convert the VideoFrame pixels to ABGR to match ...
5 years, 10 months ago (2015-02-11 09:57:38 UTC) #10
bbudge
5 years, 10 months ago (2015-02-11 15:49:26 UTC) #11
Message was sent while issue was closed. 
https://codereview.chromium.org/864113002/diff/80001/content/renderer/pepper/...
File content/renderer/pepper/video_decoder_shim.cc (right):

https://codereview.chromium.org/864113002/diff/80001/content/renderer/pepper/...
content/renderer/pepper/video_decoder_shim.cc:274: // Convert the VideoFrame
pixels to ABGR to match VideoDecodeAccelerator.
On 2015/02/11 09:57:38, dshwang wrote:
> Hi, I have a question. In this code path, video frame isn't always backed
> texture?

My understanding is that the software decoder returns a frame that is in system
memory, and that we must upload it to a texture.

Powered by Google App Engine
This is Rietveld 408576698