chrome/browser/extensions/startup_helper.cc - Issue 864093002: Move sandboxed_unpacker.{h,cc} from chrome/ to extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/startup_helper.cc

Issue 864093002: Move sandboxed_unpacker.{h,cc} from chrome/ to extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: renamed utility_content_client_, and added call to clear the UtilityClientForTesting in ~Extensions… Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/sandboxed_unpacker_unittest.cc ('k') | chrome/chrome_browser_extensions.gypi » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/startup_helper.cc

diff --git a/chrome/browser/extensions/startup_helper.cc b/chrome/browser/extensions/startup_helper.cc

index 4432e7ff819d48616d09877b621b6c295961210b..a69f73d7c4c56b3ea943378686de3722289c75d8 100644

--- a/chrome/browser/extensions/startup_helper.cc

+++ b/chrome/browser/extensions/startup_helper.cc

@@ -14,7 +14,6 @@

#include "base/strings/stringprintf.h"

#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/extensions/extension_service.h"

-#include "chrome/browser/extensions/sandboxed_unpacker.h"

#include "chrome/browser/extensions/webstore_startup_installer.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/common/chrome_switches.h"

@@ -22,6 +21,7 @@

#include "components/crx_file/id_util.h"

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/web_contents.h"

+#include "extensions/browser/sandboxed_unpacker.h"

#include "extensions/common/extension.h"

#include "ipc/ipc_message.h"

@@ -298,7 +298,7 @@ void AppInstallHelper::OnAppInstallComplete(bool success,

const std::string& error,

webstore_install::Result result) {

success_ = success;

- error_= error;

+ error_ = error;

done_callback_.Run();

}