Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 864083002: ~15x speedup without needing to use SSE. (Closed)

Created:
5 years, 11 months ago by mtklein_C
Modified:
5 years, 11 months ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

~15x speedup without needing to use SSE. On my desktop, the bench improves from ~6ms to ~0.4ms. BUG=skia: Committed: https://skia.googlesource.com/buildbot/+/0cf4ea002ea41a877c94b713a0b51e766ad8c52e

Patch Set 1 #

Patch Set 2 : tweak comments #

Patch Set 3 : fmt #

Patch Set 4 : needs to be mod 8 #

Patch Set 5 : no cgo version #

Patch Set 6 : all 0xFF #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -31 lines) Patch
M golden/go/diff/diff.go View 1 2 3 4 5 4 chunks +69 lines, -31 lines 2 comments Download

Messages

Total messages: 10 (2 generated)
mtklein_C
5 years, 11 months ago (2015-01-21 19:27:58 UTC) #2
mtklein
On 2015/01/21 19:27:58, mtklein_C wrote: I just posted up PS 5, which is a version ...
5 years, 11 months ago (2015-01-22 19:07:46 UTC) #3
mtklein
On 2015/01/22 19:07:46, mtklein wrote: > On 2015/01/21 19:27:58, mtklein_C wrote: > > I just ...
5 years, 11 months ago (2015-01-22 19:17:32 UTC) #4
mtklein
Bug fixed...
5 years, 11 months ago (2015-01-23 16:05:33 UTC) #5
jcgregorio
lgtm https://codereview.chromium.org/864083002/diff/100001/golden/go/diff/diff.go File golden/go/diff/diff.go (right): https://codereview.chromium.org/864083002/diff/100001/golden/go/diff/diff.go#newcode211 golden/go/diff/diff.go:211: if dr+dg+db > 0 { I would like ...
5 years, 11 months ago (2015-01-23 16:19:54 UTC) #6
mtklein
https://codereview.chromium.org/864083002/diff/100001/golden/go/diff/diff.go File golden/go/diff/diff.go (right): https://codereview.chromium.org/864083002/diff/100001/golden/go/diff/diff.go#newcode211 golden/go/diff/diff.go:211: if dr+dg+db > 0 { On 2015/01/23 16:19:54, jcgregorio ...
5 years, 11 months ago (2015-01-23 16:42:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864083002/100001
5 years, 11 months ago (2015-01-23 16:43:12 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 16:43:16 UTC) #10
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/buildbot/+/0cf4ea002ea41a877c94b713a0b51e766ad8...

Powered by Google App Engine
This is Rietveld 408576698