Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Side by Side Diff: Source/core/html/track/vtt/VTTScanner.cpp

Issue 864043002: WebVTT: Support fractional percentage values for position/line/size (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Moar tests. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/track/vtt/VTTScanner.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013, Opera Software ASA. All rights reserved. 2 * Copyright (c) 2013, Opera Software ASA. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 if (m_is8Bit) 161 if (m_is8Bit)
162 number = charactersToFloat(integerRun.start(), lengthOfFloat, &validNumb er); 162 number = charactersToFloat(integerRun.start(), lengthOfFloat, &validNumb er);
163 else 163 else
164 number = charactersToFloat(reinterpret_cast<const UChar*>(integerRun.sta rt()), lengthOfFloat, &validNumber); 164 number = charactersToFloat(reinterpret_cast<const UChar*>(integerRun.sta rt()), lengthOfFloat, &validNumber);
165 165
166 if (!validNumber) 166 if (!validNumber)
167 number = std::numeric_limits<float>::max(); 167 number = std::numeric_limits<float>::max();
168 return true; 168 return true;
169 } 169 }
170 170
171 bool VTTScanner::scanPercentage(float& percentage)
172 {
173 Position savedPosition = position();
174 if (!scanFloat(percentage))
175 return false;
176 if (scan('%'))
177 return true;
178 // Restore scanner position.
179 seekTo(savedPosition);
180 return false;
171 } 181 }
182
183 }
OLDNEW
« no previous file with comments | « Source/core/html/track/vtt/VTTScanner.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698