Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 863983003: Reland https://codereview.chromium.org/860333002 with fix for test failures. (Closed)

Created:
5 years, 11 months ago by bsalomon
Modified:
5 years, 11 months ago
Reviewers:
brian1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reland https://codereview.chromium.org/860333002 with fix for test failures. Revert "Revert of Make GrScratchKey memory buffer correct size on copy (patchset #1 id:1 of https://codereview.chromium.org/860333002/)" This reverts commit 988018c817f341c0ce09297b7ba5ba60ba76eba9. BUG=skia: Committed: https://skia.googlesource.com/skia/+/1c60dfe7ca0db010fa3118a1a2c7ff4c09136ab0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -38 lines) Patch
M include/gpu/GrResourceKey.h View 2 chunks +5 lines, -3 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 12 chunks +141 lines, -35 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863983003/1
5 years, 11 months ago (2015-01-21 16:59:59 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-21 17:00:00 UTC) #3
brian1
On 2015/01/21 17:00:00, I haz the power (commit-bot) wrote: > Note for Reviewers: > The ...
5 years, 11 months ago (2015-01-21 17:32:04 UTC) #4
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 17:32:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1c60dfe7ca0db010fa3118a1a2c7ff4c09136ab0

Powered by Google App Engine
This is Rietveld 408576698