Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 863933004: Linux sandbox: Make ChrootToSafeEmptyDir() faster. (Closed)

Created:
5 years, 11 months ago by jln (very slow on Chromium)
Modified:
5 years, 11 months ago
CC:
chromium-reviews, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Linux sandbox: Make ChrootToSafeEmptyDir() faster. Use a vfork()-like system call instead of fork() in ChrootToSafeEmptyDir() to avoid duplicating page tables, which is slow. BUG=312380 Committed: https://crrev.com/1753adb1e43060ec322880f9a7bf9b483bac0ace Cr-Commit-Position: refs/heads/master@{#312732}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -16 lines) Patch
M sandbox/linux/services/credentials.cc View 4 chunks +34 lines, -16 lines 0 comments Download
M sandbox/linux/services/credentials_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jln (very slow on Chromium)
Ricky: PTAL!
5 years, 11 months ago (2015-01-22 23:04:11 UTC) #2
rickyz (no longer on Chrome)
lgtm
5 years, 11 months ago (2015-01-22 23:27:09 UTC) #3
jln (very slow on Chromium)
Jorge, would you mind stamping this?
5 years, 11 months ago (2015-01-22 23:34:28 UTC) #5
Jorge Lucangeli Obes
lgtm
5 years, 11 months ago (2015-01-23 00:03:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863933004/1
5 years, 11 months ago (2015-01-23 00:12:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 01:26:01 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 01:26:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1753adb1e43060ec322880f9a7bf9b483bac0ace
Cr-Commit-Position: refs/heads/master@{#312732}

Powered by Google App Engine
This is Rietveld 408576698