Issue 863883002: Eliminate RuleRange.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 863883002: Eliminate RuleRange. (Closed)

Created:
5 years, 11 months ago by esprehn

Modified:
5 years, 11 months ago

Reviewers:
ojan

CC:
ojan, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Eliminate RuleRange. In Sky there's no UA rules so we don't need to keep track of the range of UA vs Author rules for running applyMatchedProperties later. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/55ec6d0ca5ebd27b61a4e48f9d0c439853a39ad4

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -127 lines)			Patch
M	sky/engine/core/css/ElementRuleCollector.h	View	3 chunks	+6 lines, -7 lines	0 comments	Download
M	sky/engine/core/css/ElementRuleCollector.cpp	View	4 chunks	+8 lines, -16 lines	0 comments	Download
M	sky/engine/core/css/resolver/MatchResult.h	View	2 chunks	+2 lines, -59 lines	0 comments	Download
M	sky/engine/core/css/resolver/MatchResult.cpp	View	1 chunk	+1 line, -10 lines	0 comments	Download
M	sky/engine/core/css/resolver/MatchedPropertiesCache.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	sky/engine/core/css/resolver/MatchedPropertiesCache.cpp	View	3 chunks	+2 lines, -5 lines	0 comments	Download
M	sky/engine/core/css/resolver/ScopedStyleResolver.cpp	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	sky/engine/core/css/resolver/StyleResolver.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/css/resolver/StyleResolver.cpp	View	6 chunks	+12 lines, -22 lines	0 comments	Download

Total messages: 3 (1 generated)

esprehn

5 years, 11 months ago (2015-01-21 03:50:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
55ec6d0ca5ebd27b61a4e48f9d0c439853a39ad4 (presubmit successful).