Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 863863007: Add support for wrapping the standalone JavaScript. (Closed)

Created:
5 years, 10 months ago by nyquist
Modified:
5 years, 10 months ago
Reviewers:
cjhopman
Base URL:
git@github.com:chromium/dom-distiller.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for wrapping the standalone JavaScript. The standalone JavaScript file needs to be wrapped when injected into real pages in Chrome, to ensure that it does not change the real window object. This CL adds such a wrapper JavaScript and functionality to automatically build it when packaging the output. BUG=455503 R=cjhopman@chromium.org Committed: 28127442150e0332e0c289539d4ae702139a52c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -2 lines) Patch
M build.xml View 2 chunks +12 lines, -2 lines 0 comments Download
A create_wrapped_standalone_js.py View 1 chunk +53 lines, -0 lines 0 comments Download
A war/wrapped_domdistiller_template.js View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nyquist
cjhopman: PTAL
5 years, 10 months ago (2015-02-05 01:41:08 UTC) #2
cjhopman
lgtm
5 years, 10 months ago (2015-02-05 01:54:58 UTC) #3
nyquist
5 years, 10 months ago (2015-02-05 21:56:47 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
28127442150e0332e0c289539d4ae702139a52c7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698