Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 863863005: Prevent the default select-all behavior from happening in OOP PDF (Closed)

Created:
5 years, 10 months ago by raymes
Modified:
5 years, 7 months ago
CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent the default select-all behavior from happening in OOP PDF BUG=454335 Committed: https://crrev.com/861230ece8eb56fe835283b9fba9a538f26ab582 Cr-Commit-Position: refs/heads/master@{#314277}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/resources/pdf/pdf.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
raymes
5 years, 10 months ago (2015-02-03 01:38:36 UTC) #2
Sam McNally
lgtm
5 years, 10 months ago (2015-02-03 01:42:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863863005/1
5 years, 10 months ago (2015-02-03 01:47:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (None)
5 years, 10 months ago (2015-02-03 03:49:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863863005/1
5 years, 10 months ago (2015-02-03 04:14:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 06:12:12 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/861230ece8eb56fe835283b9fba9a538f26ab582 Cr-Commit-Position: refs/heads/master@{#314277}
5 years, 10 months ago (2015-02-03 06:13:15 UTC) #11
Ryan Sleevi
5 years, 7 months ago (2015-05-11 06:21:53 UTC) #14
Message was sent while issue was closed. 
https://codereview.chromium.org/863863005/diff/60001/content/browser/renderer...
File content/browser/renderer_host/pepper/pepper_socket_utils.h (right):

https://codereview.chromium.org/863863005/diff/60001/content/browser/renderer...
content/browser/renderer_host/pepper/pepper_socket_utils.h:54: 
Is there a reason we don't record these metrics for all plugins?

https://codereview.chromium.org/863863005/diff/60001/content/browser/renderer...
File content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc
(right):

https://codereview.chromium.org/863863005/diff/60001/content/browser/renderer...
content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc:652:
ppapi::host::ReplyMessageContext reply_context(context);
Doesn't this only go based on the plugin's URL, not the effective origin?

That is, if I had an HTTP page framing an HTTPS iframe, this would report as
HTTPS, right?

Powered by Google App Engine
This is Rietveld 408576698