Source/core/animation/EffectInput.cpp - Issue 863863004: Implemented additive animations for length

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/animation/EffectInput.cpp

Issue 863863004: Implemented additive animations for length (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed AnimationStackTest Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/core/animation/AnimationStack.cpp ('K') | « Source/core/animation/ConstantStyleInterpolation.h ('k') | Source/core/animation/InterpolableValue.h » ('j') | Source/core/animation/Interpolation.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All rights reserved.	2 * Copyright (C) 2013 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 93 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
104 DictionaryHelper::get(keyframeDictionary, property, value);	104 DictionaryHelper::get(keyframeDictionary, property, value);

105 keyframe->setPropertyValue(id, value, styleSheetContents);	105 keyframe->setPropertyValue(id, value, styleSheetContents);

106 }	106 }

107 }	107 }

108	108

109 RefPtrWillBeRawPtr<StringKeyframeEffectModel> keyframeEffectModel = StringKe yframeEffectModel::create(keyframes);	109 RefPtrWillBeRawPtr<StringKeyframeEffectModel> keyframeEffectModel = StringKe yframeEffectModel::create(keyframes);

110 if (keyframeEffectModel->hasSyntheticKeyframes()) {	110 if (keyframeEffectModel->hasSyntheticKeyframes()) {

111 exceptionState.throwDOMException(NotSupportedError, "Partial keyframes a re not supported.");	111 exceptionState.throwDOMException(NotSupportedError, "Partial keyframes a re not supported.");

112 return nullptr;	112 return nullptr;

113 }	113 }

114 if (!keyframeEffectModel->isReplaceOnly()) {	114 if (!keyframeEffectModel->isReplaceOnly() && !RuntimeEnabledFeatures::webAni mationsAPIEnabled()) {

115 exceptionState.throwDOMException(NotSupportedError, "Additive animations are not supported.");	115 exceptionState.throwDOMException(NotSupportedError, "Additive animations are not supported.");

116 return nullptr;	116 return nullptr;

117 }	117 }

118 keyframeEffectModel->forceConversionsToAnimatableValues(element);	118 keyframeEffectModel->forceConversionsToAnimatableValues(element);

119	119

120 return keyframeEffectModel;	120 return keyframeEffectModel;

121 }	121 }

122	122

123 } // namespace blink	123 } // namespace blink

OLD	NEW