components/plugins/renderer/loadable_plugin_placeholder.h - Issue 863813002: Plugin Power Saver: Make Unthrottle metric collection more consistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/plugins/renderer/loadable_plugin_placeholder.h

Issue 863813002: Plugin Power Saver: Make Unthrottle metric collection more consistent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/plugins/chrome_plugin_placeholder.cc ('k') | components/plugins/renderer/loadable_plugin_placeholder.cc » ('j') | content/public/renderer/plugin_instance_throttler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/plugins/renderer/loadable_plugin_placeholder.h

diff --git a/components/plugins/renderer/loadable_plugin_placeholder.h b/components/plugins/renderer/loadable_plugin_placeholder.h

index 5f3748f8c2296058407b1d9fcb76b34b19fa175f..402fdc7e4d185b976f4d1fe19239e21284e505dc 100644

--- a/components/plugins/renderer/loadable_plugin_placeholder.h

+++ b/components/plugins/renderer/loadable_plugin_placeholder.h

@@ -44,7 +44,8 @@ class LoadablePluginPlaceholder : public PluginPlaceholder {

~LoadablePluginPlaceholder() override;

#if defined(ENABLE_PLUGINS)

- void DisablePowerSaverForInstance();

+ void DisablePowerSaverForInstance(

+ content::PluginInstanceThrottler::PowerSaverUnthrottleMethod method);

#endif

void OnLoadBlockedPlugins(const std::string& identifier);

@@ -111,6 +112,9 @@ class LoadablePluginPlaceholder : public PluginPlaceholder {

bool allow_loading_;

+ // True if the placeholder was replaced with the real plugin.

+ bool placeholder_was_replaced_;

bool hidden_;

bool finished_loading_;

std::string identifier_;