Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1175)

Issue 863763002: Enable find-missing-symbols-at-link-time for static builds too. (Closed)

Created:
5 years, 11 months ago by Nico
Modified:
5 years, 11 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enable find-missing-symbols-at-link-time for static builds too. BUG=371125 R=jamesr@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/d5839bdb649c4b61e0b6d7f332e7523288981a7d

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Nico
this seems to just work
5 years, 11 months ago (2015-01-20 19:08:48 UTC) #2
jamesr
lgtm
5 years, 11 months ago (2015-01-20 20:58:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863763002/20001
5 years, 11 months ago (2015-01-20 21:03:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863763002/40001
5 years, 11 months ago (2015-01-20 21:52:15 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/d5839bdb649c4b61e0b6d7f332e7523288981a7d Cr-Commit-Position: refs/heads/master@{#312297}
5 years, 11 months ago (2015-01-20 23:09:28 UTC) #9
Nico
5 years, 11 months ago (2015-01-20 23:11:40 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
d5839bdb649c4b61e0b6d7f332e7523288981a7d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698