extensions/common/permissions/permissions_data.cc - Issue 863743002: Allow silent update for default-installed apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/permissions_data.cc

Issue 863743002: Allow silent update for default-installed apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/permissions/permissions_data.cc

diff --git a/extensions/common/permissions/permissions_data.cc b/extensions/common/permissions/permissions_data.cc

index af405273e3a698f644adf8ee081b235f57ed0ffb..16e1147ecbbcacc75a511763aae57f41878dc93d 100644

--- a/extensions/common/permissions/permissions_data.cc

+++ b/extensions/common/permissions/permissions_data.cc

@@ -51,7 +51,8 @@ void PermissionsData::SetPolicyDelegate(PolicyDelegate* delegate) {

// static

bool PermissionsData::CanSilentlyIncreasePermissions(

const Extension* extension) {

- return extension->location() != Manifest::INTERNAL;

+ return extension->location() != Manifest::INTERNAL ||

+ extension->creation_flags() & Extension::WAS_INSTALLED_BY_DEFAULT;

not at google - send to devlin 2015/02/17 17:07:24 Hm, seems odd that EXTERNAL_PREF/REGISTRY isn't ex

}

// static

« no previous file with comments | « no previous file | no next file » | no next file with comments »