Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 863723002: image subsetting as part of the name instead of a separate source type (Closed)

Created:
5 years, 11 months ago by mtklein_C
Modified:
5 years, 11 months ago
Reviewers:
stephana, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Image subsets as part of the name instead of a separate source type. This will hold us closer to the principle that the test name (and only the test name) should correspond to expected output. By the same reasoning, mix in the number of subsets: if that changes, the expected output also changes. BUG=skia:3255 Committed: https://skia.googlesource.com/skia/+/9264a95608c08623f2955823703e5c77558cafa8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M dm/DM.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M dm/DMSrcSink.cpp View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein
5 years, 11 months ago (2015-01-20 16:58:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863723002/1
5 years, 11 months ago (2015-01-20 17:22:36 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-20 17:22:37 UTC) #5
stephana
On 2015/01/20 17:22:37, I haz the power (commit-bot) wrote: > Note for Reviewers: > The ...
5 years, 11 months ago (2015-01-20 18:10:39 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 18:12:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9264a95608c08623f2955823703e5c77558cafa8

Powered by Google App Engine
This is Rietveld 408576698