Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 863693002: Use RETURN_ON_EXCEPTION rather than .Assert when setting .length, which may fail due to stack overf… (Closed)

Created:
5 years, 11 months ago by Toon Verwaest
Modified:
5 years, 11 months ago
Reviewers:
Jarin, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use RETURN_ON_EXCEPTION rather than .Assert when setting .length, which may fail due to stack overflow. BUG=449447 LOG=n Committed: https://crrev.com/ba6e1746e8992ed36360391ce3b2f517d5f5cbfe Cr-Commit-Position: refs/heads/master@{#26170}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M src/objects.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Toon Verwaest
PTAL
5 years, 11 months ago (2015-01-20 13:34:02 UTC) #2
Yang
On 2015/01/20 13:34:02, Toon Verwaest wrote: > PTAL driveby: how about adding a test case?
5 years, 11 months ago (2015-01-20 13:37:46 UTC) #3
Toon Verwaest
The existing test-case is an infinite loop if it doesn't crash. It's tricky to construct ...
5 years, 11 months ago (2015-01-20 13:57:26 UTC) #4
Yang
On 2015/01/20 13:57:26, Toon Verwaest wrote: > The existing test-case is an infinite loop if ...
5 years, 11 months ago (2015-01-20 14:13:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863693002/1
5 years, 11 months ago (2015-01-20 14:16:01 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/80)
5 years, 11 months ago (2015-01-20 15:02:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863693002/1
5 years, 11 months ago (2015-01-20 15:26:20 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-20 16:08:22 UTC) #12
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 16:08:33 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba6e1746e8992ed36360391ce3b2f517d5f5cbfe
Cr-Commit-Position: refs/heads/master@{#26170}

Powered by Google App Engine
This is Rietveld 408576698