Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: BUILD.gn

Issue 863683002: Add initial support for v8_target_arch == "arm" to GN config (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 1605495e6848228df12d8bdfcbb27348ff2fb1e0..705999e6f219a426bf391b293bfd620132856bb2 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -96,8 +96,34 @@ config("toolchain") {
defines = []
cflags = []
- # TODO(jochen): Add support for arm, mips, mipsel.
+ # TODO(jochen): Add support for arm subarchs, mips, mipsel.
+ if (v8_target_arch == "arm") {
+ defines += [ "V8_TARGET_ARCH_ARM" ]
+ if (arm_verson == 7) {
+ defines += [ "CAN_USE_ARMV7_INSTRUCTIONS" ]
+ }
+ if (arm_fpu == "vfpv3-d16") {
+ defines += [ "CAN_USE_VFP3_INSTRUCTIONS" ]
+ }
+ if (arm_fpu == "vfpv3") {
+ defines += [
+ "CAN_USE_VFP3_INSTRUCTIONS",
+ "CAN_USE_VFP32DREGS",
+ ]
+ }
+ if (arm_fpu == "neon") {
+ defines += [
+ "CAN_USE_VFP3_INSTRUCTIONS",
+ "CAN_USE_VFP32DREGS",
+ "CAN_USE_NEON",
+ ]
+ }
+
+ # TODO(jochen): Add support for arm_test_noprobe.
+
+ # TODO(jochen): Add support for cpu_arch != v8_target_arch/
+ }
if (v8_target_arch == "arm64") {
defines += [ "V8_TARGET_ARCH_ARM64" ]
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698