Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 863683002: Add initial support for v8_target_arch == "arm" to GN config (Closed)

Created:
5 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add initial support for v8_target_arch == "arm" to GN config BUG=none R=eseidel@chromium.org,brettw@chromium.org,machenbach@chromium.org LOG=n Committed: https://crrev.com/d4a69500ed373f6531467762ec20302de2c1dd69 Cr-Commit-Position: refs/heads/master@{#26162}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M BUILD.gn View 1 1 chunk +27 lines, -1 line 0 comments Download

Messages

Total messages: 9 (1 generated)
jochen (gone - plz use gerrit)
5 years, 11 months ago (2015-01-20 12:29:13 UTC) #1
jochen (gone - plz use gerrit)
Brett, any idea what to do about this: ERROR at //v8/BUILD.gn:11:20: Assignment had no effect. ...
5 years, 11 months ago (2015-01-20 13:11:29 UTC) #2
Michael Achenbach
lgtm (rubber-stamp) Unrelated: The names are a bit confusing... I assume CAN_USE_VFP32DREGS means VFP3 can ...
5 years, 11 months ago (2015-01-20 13:33:47 UTC) #3
jochen (gone - plz use gerrit)
On 2015/01/20 at 13:33:47, machenbach wrote: > lgtm (rubber-stamp) > > Unrelated: The names are ...
5 years, 11 months ago (2015-01-20 13:44:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863683002/20001
5 years, 11 months ago (2015-01-20 13:44:48 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-20 14:34:02 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d4a69500ed373f6531467762ec20302de2c1dd69 Cr-Commit-Position: refs/heads/master@{#26162}
5 years, 11 months ago (2015-01-20 14:34:20 UTC) #8
eseidel
5 years, 11 months ago (2015-01-22 18:41:27 UTC) #9
Message was sent while issue was closed.
Unfortunately this did not solve the issue. :/

Powered by Google App Engine
This is Rietveld 408576698