Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/x64/codegen-x64.cc

Issue 863633002: Use signaling NaN for holes in fixed double arrays. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Next bunch of fixes Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/arm/simulator-arm.cc ('K') | « src/serialize.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | test/mjsunit/regress/regress-undefined-nan.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/x64/codegen-x64.cc
diff --git a/src/x64/codegen-x64.cc b/src/x64/codegen-x64.cc
index ceee95488faf27b8ece14ba4f77644e8cd04f9a3..f428a9ac99f2352d74a17b2d9680ee3143d54d85 100644
--- a/src/x64/codegen-x64.cc
+++ b/src/x64/codegen-x64.cc
@@ -286,7 +286,7 @@ void ElementsTransitionGenerator::GenerateSmiToDouble(
STATIC_ASSERT(FixedDoubleArray::kHeaderSize == FixedArray::kHeaderSize);
Label loop, entry, convert_hole;
- __ movq(r15, bit_cast<int64_t, uint64_t>(kHoleNanInt64));
+ __ movq(r15, bit_cast<int64_t>(FixedDoubleArray::hole_nan_as_double()));
// r15: the-hole NaN
__ jmp(&entry);
@@ -393,7 +393,7 @@ void ElementsTransitionGenerator::GenerateDoubleToObject(
__ movp(FieldOperand(r11, FixedArray::kLengthOffset), r14);
// Prepare for conversion loop.
- __ movq(rsi, bit_cast<int64_t, uint64_t>(kHoleNanInt64));
+ __ movq(rsi, bit_cast<int64_t>(FixedDoubleArray::hole_nan_as_double()));
__ LoadRoot(rdi, Heap::kTheHoleValueRootIndex);
// rsi: the-hole NaN
// rdi: pointer to the-hole
« src/arm/simulator-arm.cc ('K') | « src/serialize.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | test/mjsunit/regress/regress-undefined-nan.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698