Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 863603003: Keep the app list start page isolated from the browser's default zoom. (Closed)

Created:
5 years, 11 months ago by benwells
Modified:
5 years, 11 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Keep the app list start page isolated from the browser's default zoom. BUG=447062 Committed: https://crrev.com/e418076d38fade53c97df5f8175d32a1acae88ba Cr-Commit-Position: refs/heads/master@{#312560}

Patch Set 1 #

Total comments: 12

Patch Set 2 : Formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M chrome/browser/ui/app_list/start_page_service.h View 1 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/start_page_service.cc View 1 3 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
benwells
5 years, 11 months ago (2015-01-20 06:30:12 UTC) #2
Matt Giuca
https://codereview.chromium.org/863603003/diff/1/chrome/browser/ui/app_list/start_page_service.cc File chrome/browser/ui/app_list/start_page_service.cc (right): https://codereview.chromium.org/863603003/diff/1/chrome/browser/ui/app_list/start_page_service.cc#newcode453 chrome/browser/ui/app_list/start_page_service.cc:453: // DidNavigateMainFrame handler. Weird place for a comment (don't ...
5 years, 11 months ago (2015-01-20 07:15:01 UTC) #3
benwells
https://codereview.chromium.org/863603003/diff/1/chrome/browser/ui/app_list/start_page_service.cc File chrome/browser/ui/app_list/start_page_service.cc (right): https://codereview.chromium.org/863603003/diff/1/chrome/browser/ui/app_list/start_page_service.cc#newcode453 chrome/browser/ui/app_list/start_page_service.cc:453: // DidNavigateMainFrame handler. On 2015/01/20 07:15:01, Matt Giuca wrote: ...
5 years, 11 months ago (2015-01-20 07:31:09 UTC) #5
Matt Giuca
https://codereview.chromium.org/863603003/diff/1/chrome/browser/ui/app_list/start_page_service.cc File chrome/browser/ui/app_list/start_page_service.cc (right): https://codereview.chromium.org/863603003/diff/1/chrome/browser/ui/app_list/start_page_service.cc#newcode498 chrome/browser/ui/app_list/start_page_service.cc:498: contents_.reset(); > I don't think it's needed. See > ...
5 years, 11 months ago (2015-01-20 22:39:23 UTC) #6
Matt Giuca
lgtm https://codereview.chromium.org/863603003/diff/1/chrome/browser/ui/app_list/start_page_service.cc File chrome/browser/ui/app_list/start_page_service.cc (right): https://codereview.chromium.org/863603003/diff/1/chrome/browser/ui/app_list/start_page_service.cc#newcode498 chrome/browser/ui/app_list/start_page_service.cc:498: contents_.reset(); Oops, as discussed offline, the WebContents destructor ...
5 years, 11 months ago (2015-01-21 00:08:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863603003/40001
5 years, 11 months ago (2015-01-21 01:14:18 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/27039)
5 years, 11 months ago (2015-01-21 02:57:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863603003/40001
5 years, 11 months ago (2015-01-21 20:14:46 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/27039)
5 years, 11 months ago (2015-01-21 20:16:44 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863603003/40001
5 years, 11 months ago (2015-01-22 03:58:26 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 11 months ago (2015-01-22 03:59:28 UTC) #18
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 04:00:19 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e418076d38fade53c97df5f8175d32a1acae88ba
Cr-Commit-Position: refs/heads/master@{#312560}

Powered by Google App Engine
This is Rietveld 408576698