Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 863593003: Add WARN_UNUSED_RESULT to [Final]Extension (Closed)

Created:
5 years, 11 months ago by scottmg
Modified:
5 years, 11 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add WARN_UNUSED_RESULT to [Final]Extension See https://codereview.chromium.org/863583002/. R=mark@chromium.org Committed: https://crrev.com/9d51ce564886367ccf2f2d00b479d65859813492 Cr-Commit-Position: refs/heads/master@{#312237}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/files/file_path.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scottmg
5 years, 11 months ago (2015-01-20 18:04:02 UTC) #1
Mark Mentovai
LGTM
5 years, 11 months ago (2015-01-20 18:05:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863593003/1
5 years, 11 months ago (2015-01-20 18:11:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-20 19:16:22 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 19:17:39 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d51ce564886367ccf2f2d00b479d65859813492
Cr-Commit-Position: refs/heads/master@{#312237}

Powered by Google App Engine
This is Rietveld 408576698